menu_get_active_help() does not support language arguments for node_edit router path [#1937852]

PHP error notice displayed when tried to edit a language version of node.

screenshot

Steps to reproduce this issue:

Install fresh D8;
Enable Content Translation module;
Edit article content type;
Enable translation under language settings;
Edit article content type, click manage fields;
Edit body;
Enable translation for body field;
In configuration, add languages;
Create test article;
Click translations tab;
Add other language versions for the node;
Click 'edit' to edit existing version of translations (Not the original copy);

The error notice will display as screenshot.

Line 135 in node module is trying to get node->type. This error displayed because the node didn't get loaded, as arg[1] is 'node' instead of nid.

Comment	File	Size	Author
#5	drupal-1937852-menu-get-active-help-4.patch	516 bytes	mradcliffe
#4	drupal-1937852-menu-get-active-help-3.patch	41.42 KB	mradcliffe
	Screenshot from 2013-03-09 12:52:34.png	41.07 KB	rli

Comments

Comment #0.0

rli

English

Canberra

commented 9 March 2013 at 02:30

Issue summary:

View changes

Giving the steps to reproduce the issue.

Comment #1

rli

English

Canberra

commented 9 March 2013 at 02:32

Assigned:

Unassigned

» rli

Comment #2

rli

English

Canberra

commented 9 March 2013 at 04:31

Component:

translation_entity.module

» language.module

Move to language module as the langcode is added into menu in language module.

Comment #3

rli

English

Canberra

commented 10 March 2013 at 00:49

Assigned:

rli

» Unassigned

Been frustrating about this. What's the point putting langcode in the menu e.g af /node/edit ? That is not doing anything unless we have translation_entity installed. And it made node_help confused.

Comment #4

mradcliffe

he/him

English

commented 18 August 2013 at 22:42

Title:	Trying to get property of non-object in node_help() (line 135 of core/modules/node/node.module)	» menu_get_active_help() does not support language arguments for node_edit router path
Component:	language.module	» language system
Priority:	Normal	» Major
Status:	Active	» Needs review
Issue tags:		+PostgreSQL, +Needs issue summary update, +Testbot environments

Status	File	Size
new	drupal-1937852-menu-get-active-help-3.patch	41.42 KB

Drupal\system\Plugin\Block\SystemHelpBlock->access() calls menu_get_active_help(), which sends in the incorrect arguments to hook_help for the node edit router path or the incorrect router path for the language arguments. node_help() loads the node entity ONLY to get the node type so that it can display the content type help (submission guidelines).

The query that is built contains a data type mismatch, which is not allowed in Postgresql.

Semi-related issues:

- #2056627: Form API autocomplete is broken for routes
- #244090: Tie help into menu router

Possible resolutions:

- Get rid of hook_help(), one of the last remaining hooks from Drupal 3. :*(
- Language, menu, or help should normalize arguments before passing in to hook_help implementation.
- Find a different way of getting the node type in node_help.

The easiest resolution is to pass the current path as the second parameter in arg(), which is what the one-line patch does.

Tests:

- A unit test that tests drupal_help_arg() output?