Hello,
Code review and make this module follow the code standerds.
Currently, there is some warning in
http://ventral.org/pareview/httpgitdrupalorgprojectblockclassgit.
#1 is my patch, thank you.

CommentFileSizeAuthor
#2 block_class-7.x-code_standard-1937930-2.patch6.06 KBGaofengzzz
#1 block_class-7.x-code_standard-1937930-1.patch6.13 KBGaofengzzz

Comments

Gaofengzzz’s picture

Gaofengzzz commented
StatusFileSize
new block_class-7.x-code_standard-1937930-1.patch6.13 KB
Gaofengzzz’s picture

Gaofengzzz commented
Status: Active » Needs work
StatusFileSize
new block_class-7.x-code_standard-1937930-2.patch6.06 KB

Pls check this patch
thank you.

Gaofengzzz’s picture

Gaofengzzz commented
Status: Needs work » Needs review
dydave’s picture

dydave commented
Status: Needs review » Fixed

Quick follow-up on this issue:

Thanks a lot for the patch and reporting this issue is certainly highly appreciated.

I have applied the patch, fixed a few more issues that you maybe missed in this patch and got all this rolled-in for the 7.x-2.x branch at 6804273.

PAReview is not prompting any errors anymore for all branches:

For all these versions, I didn't do any complicated changes, just fixed the errors as indicated by the reports: wrong spaces, break down too long inline comments, standardize Doc comments blocks, add full stops at end of lines of inline comments, break long array declarations into multiple lines, etc....

I have tested a little bit and everything seems to work as expected, but I would greatly appreciate if you could let me know if anybody encounters any issue with the latest commits related with coding standards, I would surely try doing a quick fix as soon as possible.

Lastly, after discussing a bit on IRC #drupal-contribute, I went ahead and removed the master branch:
It was perhaps the standards before the great GIT Migration (see b0959d0, which was pretty much the last time the master branch was updated), but it seems currently this branch wouldn't be needed, in particular, the default branch has been set to 7.x-2.x (this was also reported as an error on PAReview/Ventral).

Please let me know if you would have any questions, comments or issues regarding any of the commits or changes requested in this ticket, I would be glad to provide more information or explain in more details.
Thanks to all in advance for your feedback, testing and reviews.
Cheers!

dydave’s picture

dydave commented
Title: Coding standards » Make block_class module pass Coder Review

Forgot to change issue title to be more explicit.

Thanks to all for your feedback, testing and reporting.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.