The check for whether or not to clone a menu item is currently set to test if the menu component is empty:
if (!empty($old->menu)) {

The issue with this in testing is that if no menu item is defined it still often has the array built, just with empty values inside of the menu. This will make it appear that menu is set even though it's not.

A proper test would be against any of the properties inside of menu.

CommentFileSizeAuthor
#1 og_clone-menu-cloning-none-1940982-1.patch503 bytesbtopro

Comments

btopro’s picture

btopro commented
Status: Needs work » Needs review
StatusFileSize
new og_clone-menu-cloning-none-1940982-1.patch503 bytes

Patch to test against link_title, a required field for a menu to be valid.