#1241938: Add support for #placeholder to relevant Field API widgets was committed to core before telephone module was, so we need to ensure that we support editing the placeholder value for telephone widgets as well.

CommentFileSizeAuthor
#1 1942902-telephone-widget-placeholder-option.patch3.26 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
1942902-telephone-widget-placeholder-option.patch3.26 KB

Patch that adds the same widget functionality and tests that the email module has.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

And yes, I consider this a bug since the other field types that support placeholders have this option, but telephone doesn't.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs review » Reviewed & tested by the community

This one makes sense to me, especially since it makes the telephone field type behave like the email field type. The patch applied cleanly for me and the tests worked correctly.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

#1: 1942902-telephone-widget-placeholder-option.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Quick fix
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.