I doubt anyone upgrading from D7 to D8 can access the admin/structure/taxonomy page after field_ui_update_8001 is ran.

CommentFileSizeAuthor
#3 1944344-3-fail.patch453 bytesswentel
#3 1944344-3.patch2.33 KBswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Priority: Normal » Major

Pinged the folks in #611294: Refine permissions for Field UI.

field_ui_update_8001() deletes 'administer comments', 'administer content types', 'administer users', 'administer taxonomy' from existing roles, , but the actual perms are still:
- exposed in the respective comment_permission(), node_permission(), etc...
- used for actual access checks (access menu callbacks...)
- used in lots of tests (drupalCreateUser())

Seems major at least :-)

swentel’s picture

swentel CreditAttribution: swentel commented
Assigned: Unassigned » swentel

Wow, how the hell did I miss that, I'll fix this.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Active » Needs review
FileSize
1944344-3.patch2.33 KB
1944344-3-fail.patch453 bytes

Djee, what was I thinking removing that old permission ..

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Sounds reasonable :-)
RTBC if green.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Oops. :P

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.