O.K No one seem to have made an issue that is just for this one task.

This is just one thing, nothing more, nothing less. Update jQuery UI to 1.10.2.

I'm attaching two patches for review. One is the simple patch without the actual jquery_UI changes because that's useless in a diff. The other one is the official patch I plan on committing with the updated jquery UI.

Comments

ericduran’s picture

There is some views issue with the latest version of jQuery UI. That being said the issue is not with jquery_update so it should be fixed with views.

The views fix is over at #1947444: Do not always apply the jQuery UI dialog patch.. Patch already attached on that issue.

ericduran’s picture

Category: bug » feature
Status: Active » Needs review
OnkelTem’s picture

Priority: Normal » Major

Buggy jQuery UI 1.8.11 should be lustrated ASAP.
Reference: http://drupal.org/node/1908174

ericduran’s picture

@OnkelTem yep, if you test it, I'll committed it sooner :)

ericduran’s picture

Category: feature » bug
Priority: Major » Critical

Also changing to bug and critical.

hswong3i’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new2.8 MB

A reformat of patch with following command:

git format-patch drupal/7.x-2.x -M -C -s --keep-subject --stdout > ~/jquery_update-ui-1.10.2-1947438-6.patch

Nothing else changed. Also tested together with #1947444: Do not always apply the jQuery UI dialog patch. at least editing a views looks works.

ericduran’s picture

I don't need the format patch being that I have commit access :)

Ok committing this now :) Thanks for testing.

drumm’s picture

Looks like this hasn't been committed to Git yet. Applying it does indeed clear up some Views issues for me, specifically no more Uncaught TypeError: Object function (a,b){return new p.fn.init(a,b,c)} has no method 'curCSS' originating from jQuery UI position.

Anything in particular holding this up?

drumm’s picture

(Adding a couple tags since we ran into this on the portland2013.drupal.org. I've deployed #6 there, see #1946282: Admin view of DrupalCon Portland being horribly buggy and disobedient .)

ericduran’s picture

@drumm yes, I was about to commit it, but then I realized certain jquery_ui plugins were moved. This works ok for most plugins.

But the effects need to be fixed. I'm currently working on a proper fix this.

ericduran’s picture

Status: Reviewed & tested by the community » Fixed

This is now fixed.

I had to fix the ui pattern, but it only took a min.

Currently the way to to update these version isn't great. I'm going to open a new issue to improve the process also there's no test in this project :-(

--
http://drupalcode.org/project/jquery_update.git/commit/d32f50d

OnkelTem’s picture

Currently the way to to update these version isn't great. I'm going to open a new issue to improve the process also there's no test in this project :-(

Do you mean it's not ready yet for checkout?

UPDATE. I've just checked this out, smooth sailing. Not to say I've tested that much though...

ericduran’s picture

@OnkelTem the module is ok for use. I was talking more about for development purpose. It's not very straight forward to update the module when new versions of jquery or jquery_ui come out. Not to mention it's really hard to know if you broke something :)

westwesterson’s picture

'Fixing' this bug created a new one:
http://drupal.org/node/1953774

OnkelTem’s picture

jQuery UI 1.10.2 and jQuery 1.5? Are they supposed to work together after all?

westwesterson’s picture

no, sadly jquery 1.5 and jquery ui 1.10.2 do not work together thats why i created the new bug, since this already landed.

For me, everything higher than jquery 1.5 breaks states in views, and there is no option to use standard drupal jquery/jquery ui, so things in dev are broken right now considering, views is almost a core module.

ericduran’s picture

@westwesterson with the latest dev version 1.7 and 1.8 all work with views.

Once I fix a couple more bugs I'll put out a new release.

westwesterson’s picture

StatusFileSize
new189.87 KB

@ericduran Not for me, see attached screenshot of dropdowns not working with 1.7 (or 1.8)

OnkelTem’s picture

@westwesterson with the latest dev version 1.7 and 1.8 all work with views.

But if jQuery UI 1.10.2 is incompatible with jQuery < 1.6 we can't do much, right? See the patch: #1953774-2: jquery UI 1.10.2 does not work with jquery 1.5

@ericduran Not for me, see attached screenshot of dropdowns not working with 1.7 (or 1.8)

Btw, I had the same issue until I upgraded to the latest Views dev. But I don't remember my jQuery Update settings at that moment.

ericduran’s picture

Yes, sorry You need the latest dev of Views and Jquery_update. Views had to be fixed because it was patching jquery_Ui.

Note jQuery Update will never work with < jquery 1.6.

Sadly you need to run the latest version of views and jquery update. That being said you can just apply the patch I submitted to views if running views on the latest Dev seems risky to someone.

Also key here is the latest dev version.

OnkelTem’s picture

Note jQuery Update will never work with < jquery 1.6.

You probably mean jQuery UI, which will never work with jQuery < 1.6, huh? Because jQuery Update ships with jQuery 1.5 :)

ericduran’s picture

@OnkelTem :) Yes Yes, That.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kaka’s picture

haven't understood how and what patch to apply!! Can someone help me? I need support for jquery 1.10.2 in order to integrate qtip2. Regards, Samuele.

ianthomas_uk’s picture

Is there expected to be a 7.x-2.4 out soon? We're using some third party code that depends on jQuery UI 1.10 and would much prefer to run released versions of modules than random checkouts.

aethr’s picture

Issue summary: View changes
StatusFileSize
new1.06 KB

I applied the 'complete' patch from the OP and it's been working great, thanks!

I had one issue with Media 7.x-1.3 where the Media Browser Library tab stopped working, as it relied on a jquery.ui.tabs event that has been deprecated in jQuery UI 1.10.

I fixed the issue locally and manually rolled a patch for the Media module, which I am successfully applying via drush makefile.

I'm fairly new to contributing and wasn't sure where / how to post my patch, but I figured I'd post it here in case anyone else is trying to use the patch from the OP with the Media module. Sorry if this is the wrong place for this!

ianthomas_uk’s picture

@aethr Thanks for the patch.

Patches should be posted against the project they are for, in this case https://drupal.org/project/issues/media (you'll probably need to create a new issue over there), then add links between the issues so if people find one they can find the other.

To help reviewers, please link to the relevant documentation that shows what has changed in jQuery UI. If something's just been deprecated then it should still work though, are you sure it wasn't deprecated in an earlier release and removed in 1.10? Will your patch break anything if people don't have jQuery Update installed?

aethr’s picture

Thanks @ianthomas_uk, I did suspect this was the wrong place.

This issue will only affect sites with Media 7.x-1.x when they have applied the patch in this issue which provides jQuery UI 1.10. That's why I didn't post the patch in Media, even though it's a patch to the Media module.

As far as I can tell, the Media module code that I fixed is binding to an event "tabsshow" that is no longer used in jQuery tabs 1.10, which is replaced by an event called "activate" that has different arguments.

Anyway, it probably makes sense to create a Media issue simply because site creators will know that a piece of Media functionality isn't working, but they may not be aware that jQuery Update is the culprit. I will try to clean this issue up and simply link to it once I've done that.

Cheers!

aethr’s picture

aethr’s picture

Apologies for cluttering up the thread, my issue was already raised (and a nearly identical patch uploaded) here: https://drupal.org/node/2089697

If anyone is able to remove my comments and patch from this issue, feel free. :)

klonos’s picture

Title: Update jQuery UI to the latest version (1.10.2) » Update jQuery UI to the latest version (1.10.4)
Status: Closed (fixed) » Active

1.10.4 is out:

http://code.jquery.com/ui/1.10.4/jquery-ui.js
http://code.jquery.com/ui/1.10.4/jquery-ui.min.js

Also the project's page still says:

Drupal 7 to jQuery 1.5.1/1.7.1/1.8.2, 1.9.1, 1.10.2 and jQuery UI 1.10.1 (in dev branch 7.x-2.x-dev)

...we need to update that anyways because the version we ship dev with is 1.10.2, but once we get 1.10.4 in we should remember to re-update and generally remember to update it each time we update the version we ship with (including /replace/ui/version.txt).

ianthomas_uk’s picture

Title: Update jQuery UI to the latest version (1.10.4) » Update jQuery UI to the latest version (1.10.2)
Status: Active » Closed (fixed)

@klonos that deserves its own issue. This one has been fixed.