Now that #1911970: The audio, image, and video file types should default to a wildcard mimetype selector has been committed which defaults the video file type to include all video/* mimetypes, the problematic code in media_youtube_update_7202() should be wiped out so that it does nothing. This update hook should have been an indication at a problem in the configurable file types which has now been fixed.

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Title: Remove media_youtube_update_7202() » Remove media_youtube_update_7202() and media_youtube_file_default_types_alter()

media_youtube_file_default_types_alter() also needs to be removed

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Fixed

Fixed with http://drupalcode.org/project/media_youtube.git/commit/93c7a60

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

Would we need to do the same thing for media_vimeo?

function media_vimeo_file_default_types_alter(&$types) {
  $types['video']->mimetypes[] = 'video/vimeo';
}
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Correct, you'd want to remove that function as well. But not the media_vimeo_file_mimetype_mapping_alter() function.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

Here is the same issue for media_vimeo with a similar patch posted #1950188: Remove media_vimeo_update_7200() and media_vimeo_file_default_types_alter()

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.