I've been testing out the navbar on a custom theme and it was working out well. I then added the FontAwesome css to my theme and noticed that the navbar menu started breaking visually.

What's happening is the tag with the class of .icon is conflicting with the styles of FontAwesome.

ex: <a href="/admin/config" id=navbar-link-admin-config" class="icon icon-configuration">Configuration</a>

Both the .icon and .icon- have a high probability of conflicting.

I realize that this may not be a bug with this module per-say, but I wanted to make sure the issue is raised as font awesome and bootstrap are becoming more popular with drupal themes.

CommentFileSizeAuthor
#4 navbar-use-navbar-icon-class-1955912-4.patch13.28 KBshadcn

Comments

caschbre’s picture

caschbre commented

This may be a duplicate of #1757466: Prefix all navbar classes to prevent theme clashes.

Can someone confirm that?

jessebeach’s picture

jessebeach commented

Noted, thank you.

jessebeach’s picture

jessebeach commented
Status: Active » Closed (duplicate)

Duplicate of #1757466: Prefix all navbar classes to prevent theme clashes.

shadcn’s picture

shadcn commented
StatusFileSize
new navbar-use-navbar-icon-class-1955912-4.patch13.28 KB

Hi

I'd like to reopen this issue since the patch in #1757466: Prefix all navbar classes to prevent theme clashes fixes the conflict with the generic 'navbar' class and not 'icon' classes. I'm attaching a patch to use a 'navbar-icon' class instead.

Thanks ^^

shadcn’s picture

shadcn commented
Status: Closed (duplicate) » Active
hass’s picture

hass commented

Duplicate of #1938044: Prefix all toolbar classes to prevent theme clashes!!!

Kristina Katalinic’s picture

Kristina Katalinic commented

Hi, how do I apply this patch from Mac terminal please?

shadcn’s picture

shadcn commented

@Kristina See https://drupal.org/patch/apply

hass’s picture

hass commented
Status: Active » Closed (duplicate)
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

This patch here should also fix this problem: #1757466: Prefix all navbar classes to prevent theme clashes - it's a back port of the Drupal 8 Toolbar patch that @hass mentions in comment #6.