$view = &$form_state['view']; is not needed in PHP5. When it is an object, it shouldn't have an & for reference, it is redundant.

This should be done right before code freeze. Here's a patch to get started.

Files: 
CommentFileSizeAuthor
#18 1959338-18.patch18.15 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 59,668 pass(es).
[ View ]
#18 interdiff-1959338-18.txt764 bytesdamiankloip
#16 php4_style_references-1959338-16.patch18.22 KBsuperspring
FAILED: [[SimpleTest]]: [MySQL] 59,298 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#14 php4_style_references-1959338-14.patch958 bytessuperspring
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch php4_style_references-1959338-14.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#12 php4_style_references-1959338-12.patch18.27 KBsuperspring
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php.
[ View ]
#7 1959338-reroll-views.patch218.77 KBurwen
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1959338-reroll-views.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 views-object-reference-rerolled-2013-05-25.patch20.5 KBurwen
PASSED: [[SimpleTest]]: [MySQL] 55,750 pass(es).
[ View ]
views-object-reference.patch20.61 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-object-reference.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:Unassigned» urwen

I will work on it as part of the Drupal London sprint may 2013

I think it must be something wrong with the last patch, if someone could guide me through where to continue?

alex@alex-Vostro-V13 /var/www/drupal $ git apply --index views-object-reference.patch
error: core/modules/views/lib/Drupal/views/ManyToOneHelper.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Php.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Php.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Tests/Handler/FieldWebTest.php: does not match index
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: does not match index
error: core/modules/views/views.module: does not match index
error: core/modules/views/views.theme.inc: does not match index
error: core/modules/views/views_ui/admin.inc: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/AddItem.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Analyze.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemExtra.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/EditDetails.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php: does not exist in index

Title:Remove PHP4-style references for objectsreroll: Remove PHP4-style references for objects
StatusFileSize
new20.5 KB
PASSED: [[SimpleTest]]: [MySQL] 55,750 pass(es).
[ View ]

ok, sorry, I found the problem. I've recreated the patch again following this instructions: http://drupalladder.org/lesson/b93deb54-264f-19a4-49eb-db74bc6c2712

Status:Postponed» Needs review

Hi tim.plunkett,

I have a quick question. I don't understand these changes:

- $options =& $form_state['values']['options'];
+ $options = &$form_state['values']['options'];

I guess it is simply coding standards, isn't it?

Thanks a lot.

there we go, here is the full patch for views and views_ui

StatusFileSize
new218.77 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1959338-reroll-views.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

sorry, I forgot to attach the patch.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 1959338-reroll-views.patch, failed testing.

Status:Needs work» Needs review

#7: 1959338-reroll-views.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, 1959338-reroll-views.patch, failed testing.

Issue tags:+Needs reroll

Assigned:urwen» superspring
Status:Needs work» Needs review
StatusFileSize
new18.27 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php.
[ View ]

So here is my attempt at a re-roll for this patch.

A quick grep shows quite a few other changes that this no longer reflects.
If this passes the tests I'll add some more of them to the patch.

Status:Needs review» Needs work

The last submitted patch, php4_style_references-1959338-12.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new958 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch php4_style_references-1959338-14.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Attempt two

Status:Needs review» Needs work

The last submitted patch, php4_style_references-1959338-14.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new18.22 KB
FAILED: [[SimpleTest]]: [MySQL] 59,298 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Attempt three

Status:Needs review» Needs work

The last submitted patch, php4_style_references-1959338-16.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new764 bytes
new18.15 KB
PASSED: [[SimpleTest]]: [MySQL] 59,668 pass(es).
[ View ]

Nice work superspring. I think an old underscored method call crept back in somehow :)

Status:Needs review» Reviewed & tested by the community

Each line looks really fine.

Issue tags:-Needs reroll

Removed "Needs reroll" because latest patch is RTBC

18: 1959338-18.patch queued for re-testing.

Issue summary:View changes
Status:Reviewed & tested by the community» Fixed

Yay, less cruft! :)

Committed and pushed to 8.x. Thanks!

great to know that my name will be in D8 :-)

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.