reroll: Remove PHP4-style references for objects

I will work on it as part of the Drupal London sprint may 2013

I think it must be something wrong with the last patch, if someone could guide me through where to continue?

alex@alex-Vostro-V13 /var/www/drupal $ git apply --index views-object-reference.patch
error: core/modules/views/lib/Drupal/views/ManyToOneHelper.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument_default/Php.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/argument_validator/Php.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.php: does not match index
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: does not match index
error: core/modules/views/lib/Drupal/views/Tests/Handler/FieldWebTest.php: does not match index
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: does not match index
error: core/modules/views/views.module: does not match index
error: core/modules/views/views.theme.inc: does not match index
error: core/modules/views/views_ui/admin.inc: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/AddItem.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Analyze.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemExtra.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Display.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/EditDetails.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php: does not exist in index
error: core/modules/views/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php: does not exist in index

ok, sorry, I found the problem. I've recreated the patch again following this instructions: http://drupalladder.org/lesson/b93deb54-264f-19a4-49eb-db74bc6c2712

Hi tim.plunkett,

I have a quick question. I don't understand these changes:

- $options =& $form_state['values']['options'];
+ $options = &$form_state['values']['options'];

I guess it is simply coding standards, isn't it?

Thanks a lot.

there we go, here is the full patch for views and views_ui

sorry, I forgot to attach the patch.

#7: 1959338-reroll-views.patch queued for re-testing.

So here is my attempt at a re-roll for this patch.

A quick grep shows quite a few other changes that this no longer reflects.
If this passes the tests I'll add some more of them to the patch.

Attempt two

Attempt three

Nice work superspring. I think an old underscored method call crept back in somehow :)

Each line looks really fine.

Removed "Needs reroll" because latest patch is RTBC

18: 1959338-18.patch queued for re-testing.

Yay, less cruft! :)

Committed and pushed to 8.x. Thanks!

great to know that my name will be in D8 :-)