Now that #1958264: Settings for displaying hidden files are all broken is working, dfletcher and I just uncovered some other bugs in how we handle the display hidden files.

The header for the table of visible files is always being rendered, even if there are no visible files.

CommentFileSizeAuthor
#2 1961676_0.patch713 bytesdfletcher

Comments

dfletcher’s picture

dfletcher commented
Assigned: Unassigned » dfletcher
dfletcher’s picture

dfletcher commented
Status: Active » Needs review
StatusFileSize
new 1961676_0.patch713 bytes

Very strange, this patch also fixes https://drupal.org/node/1961678

The odd thing is that was not intentional. As written, the patch just makes sure $rows is not empty before making the top table.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Yeah, very strange. I just spent ~30 minutes on this and #1961678: If there's only 1 hidden file in the field, it is not displayed in a separate table at all and also couldn't find the underlying bug that was really causing #1961678. Hrmph. Anyway, committed and pushed this since it's obviously worth doing.

Thanks!
-Derek

jthorson’s picture

jthorson commented
Project: Attached Files Metadata Table » Extended File Field

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 214e744 on 7.x-1.x, empty-file-2150029 authored by dfletcher, committed by dww: 
    [#1961676] by dfletcher: Only render table if there are visible files.