This module will simply create one new content type called Greetings and one block with label Greetings. Move the Greetings block to any region that where you want to display the message, This module will help to convey any important information to your site visitors on any specific day without fail, like any new feature added to the site or any special offers you want to give to your customers etc..,

Project Url: http://drupal.org/sandbox/venkatadapa/1281922

Git Url: git clone --branch 6.x-1.x venkatadapa@git.drupal.org:sandbox/venkatadapa/1281922.git greetings

Comments

SamChez’s picture

For starters there's a license.txt file that shouldn't be there as Drupal adds it for you. Also in your greetings.info file your 5th line, where you put the version info, it is also automatically added by Drupal. You should follow proper naming convention when it comes to your functions which you can read about here and remove all old CVS $Id tags. Code sniffer found some problems as well which you can see here

SamChez’s picture

Status: Needs review » Needs work
venkatadapa’s picture

Status: Needs work » Needs review
Issue tags: +Fixed all the coding standard errors

Hi SamChez,

I have fixed all the coding standard issues and updated the repository.

Please check it again.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

molenick’s picture

Hello venkatadapa, a few notes:

greetings.module
Line 62: t() is used for translating strings, so passing it an empty string is irrelevant.

The word "occasion" is mispelled throughout the module in different ways. It's good to keep the spelling consistant and accurate, especially if used in function and variable names so that there isn't confusion for people who use it and/or want to contribute to the project.

venkatadapa’s picture

Hi Molenick,

Thanks for your comments. I have changed those two points which you have mentioned.

kscheirer’s picture

Status: Needs review » Reviewed & tested by the community

You should try to remove the php logic from greetings-block.tpl.php.

No major problems though.

----
Top Shelf Modules - Enterprise modules from the community for the community.

kscheirer’s picture

Status: Reviewed & tested by the community » Fixed

In your .info file, what are pongals? I'm not sure what's going on in greetings_nodeapi() - that will be executed on any node's 'delete revision' op, not just greetings nodes.

Thanks for your contribution, venkatadapa!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Automatically closed -- issue fixed for 2 weeks with no activity.

venkatadapa’s picture

Hi Kscheirer,

Thanks a lot for providing access to promote as full project. I will definitely review other projects also and planning to contribute more modules as well. Because of having less free time, I couldn't be able to contribute since long time.

Thanks,
Venkat.

avpaderno’s picture

Issue summary: View changes
Status: Closed (fixed) » Fixed
Issue tags: -Fixed all the coding standard errors

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.