Lets get rid of those two ugly xml callbacks and turn them to views

#17 drupal-aggregator_rss_view-1955760-17.patch9.53 KBlslinnet
PASSED: [[SimpleTest]]: [MySQL] 56,640 pass(es).
[ View ]
#17 interdiff-13-to-17.txt833 byteslslinnet
#13 drupal-aggregator_rss_view-1955760-13.patch9.49 KBlslinnet
PASSED: [[SimpleTest]]: [MySQL] 56,382 pass(es).
[ View ]
#13 interdiff.txt597 byteslslinnet
#10 drupal-aggregator_rss_view-1955760-6.patch9.49 KBpguillard
PASSED: [[SimpleTest]]: [MySQL] 58,047 pass(es).
[ View ]
#10 interdiff.txt510 bytespguillard
#4 drupal-aggregator_rss_view-1955760-5.patch9.4 KBParisLiakos
PASSED: [[SimpleTest]]: [MySQL] 56,875 pass(es).
[ View ]


Status:Active» Postponed
Issue tags:+VDC

This is good since we don't have a clean way (that I am aware of) to cleaning output XML in a page hook anyway.

Status:Postponed» Active

integration is in

Title:Convert aggregator/rss and aggregator/opml to viewsConvert aggregator/rss to views
Status:Active» Needs review
new9.4 KB
PASSED: [[SimpleTest]]: [MySQL] 56,875 pass(es).
[ View ]

Lets keep OPML seperate for now, cause it needs an additional display plugin

Issue tags:+Needs manual testing

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -354,80 +354,6 @@ function aggregator_page_categories() {
-  $feed_length = config('system.rss')->get('items.view_mode');
-        $summary = text_summary($feed->description, NULL, config('aggregator.settings')->get('items.teaser_length'));

So we accept that these settings are dropped?

+++ b/core/modules/aggregator/aggregator.pages.incundefined
@@ -354,80 +354,6 @@ function aggregator_page_categories() {
-  $output .= format_rss_channel(t('@site_name aggregator', array('@site_name' => $site_name)), $url, $description, $items);

This seems to be a valid information as well.

i closed #2004622: aggregator_test output includes drupal page content as duplicate, aggregator/rss is broken atm:) this fixes it

Status:Needs review» Needs work
Issue tags:-Needs manual testing, -VDC

The last submitted patch, drupal-aggregator_rss_view-1955760-5.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Needs manual testing, +VDC

Assigned:Unassigned» pguillard

new510 bytes
new9.49 KB
PASSED: [[SimpleTest]]: [MySQL] 58,047 pass(es).
[ View ]

Apparently something has changed at the same time. This is a new patch that should be ok.

Assigned:pguillard» Unassigned

Assigned:Unassigned» lslinnet

Working on a reroll of the patch:

patching file core/modules/aggregator/aggregator.module
Reversed (or previously applied) patch detected!  Assume -R? [n] y
Hunk #1 succeeded at 152 with fuzz 1 (offset 5 lines).
patching file core/modules/aggregator/aggregator.pages.inc
Hunk #1 succeeded at 319 (offset -35 lines).
patching file core/modules/aggregator/config/views.view.aggregator_rss_feed.yml

new597 bytes
new9.49 KB
PASSED: [[SimpleTest]]: [MySQL] 56,382 pass(es).
[ View ]

This should be the reroll, including a nice little interdiff

Assigned:lslinnet» Unassigned

I checked this out manually and it seems to be fine. The only comment I'd have is that for core views we should probably have meaningful display machine names. I don't know if we've been doing that in other Views conversions, though.

Can someone reroll with a useful machine name for the displays?

Assigned:Unassigned» lslinnet

Will change the name to something meaning full as suggested.

new833 bytes
new9.53 KB
PASSED: [[SimpleTest]]: [MySQL] 56,640 pass(es).
[ View ]

Have updated the machine names so they now reflect what they are actually a list of (feed_items and feed_items_per_category)

Status:Needs review» Reviewed & tested by the community


Status:Reviewed & tested by the community» Needs work

I've seen among others @dawehner specifically request for the auto-generated display names (i.e. feed_1, etc.) to stay. I don't know why that is, and I also find meaningful names, well..., more meaningul!, but I give him the benefit of the doubt that this has a reason.

Status:Needs work» Reviewed & tested by the community

To be honest this is just personal preference (and the feeling that people overuse this feature), so I will not block that.

Issue tags:+RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Issue summary update