Clean up the CSS for Color module [#1969132]

Part of the CSS Cleanup: #1968914: [META] Sprint CSS cleanup

Overview of Goals

Make it easy to remove unwanted design assumptions in the theme layer, while maintaining critical functionality.
Prevent unneeded administrative styles from loading on the front end.
Make CSS and related markup more efficient and less intrusive to improve the themer experience.

Comment	File	Size	Author
#3	color-module-css-cleanup-1969132-3.patch	2.78 KB	rteijeiro
#3
#1	1969132-color_module-css-clean-up-1.patch	3.85 KB	oresh
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

oresh CreditAttribution: oresh commented 12 April 2013 at 20:38

Status:

Active

» Needs review

File	Size
1969132-color_module-css-clean-up-1.patch	3.85 KB

First attempt.
Replacing id with class in css - reducing selectors weight.

Comment #2

djbobbydrake CreditAttribution: djbobbydrake commented 24 May 2013 at 23:37

Status:

Needs review

» Needs work

I would not remove the IDs form the markup, nor replace the ID selectors with css selectors on the JS side, because ID selectors are much more efficient than class selectors on the JS side. The changes in the css files are okay, though.