Follow up for #1953404: Add config schema to field and instance config entities

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.

Proposed solution

Create a configuration schema for field types, field widget and field storage (if applicable) defined in number module.
Schema in place

Schema not yet in place
field.number_integer.settings
field.number_integer.instance_settings
field.number_integer.value

field.number_decimal.settings
field.number_decimal.instance_settings
field.number_decimal.value

field.number_float.settings
field.number_float.instance_settings
field.number_float.value

field_widget.number.settings

Files: 
CommentFileSizeAuthor
#8 1973450-config-schema-field-number-8.patch2.35 KByched
PASSED: [[SimpleTest]]: [MySQL] 57,163 pass(es).
[ View ]
#7 1973450-config-schema-field-number-7.patch2.63 KBAjitS
PASSED: [[SimpleTest]]: [MySQL] 56,964 pass(es).
[ View ]
#6 1973450-config-schema-field-number-6.patch2.63 KBAjitS
PASSED: [[SimpleTest]]: [MySQL] 56,842 pass(es).
[ View ]
#1 1973450-config-schema-field-number-1.patch2.77 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 54,752 pass(es).
[ View ]
#1 field.field_.integer.form_.png34.2 KBvijaycs85
#1 field.instance.integer.form_.png43.77 KBvijaycs85
#1 field.field_.decimal.form_.png35.28 KBvijaycs85
#1 field.instance.decimal.form_.png42.75 KBvijaycs85
#1 field.field_.float_.form_.png34.9 KBvijaycs85
#1 field.instance.float_.form_.png48.68 KBvijaycs85

Comments

Status:Active» Needs review
StatusFileSize
new48.68 KB
new34.9 KB
new42.75 KB
new35.28 KB
new43.77 KB
new34.2 KB
new2.77 KB
PASSED: [[SimpleTest]]: [MySQL] 54,752 pass(es).
[ View ]

Initial patch with config_inspector forms..

Component:field system» number.module

+++ b/core/modules/number/config/schema/number.schema.ymlundefined
@@ -0,0 +1,127 @@
+# Schema for configuration files of the Number module.

The config schema for text does not capitalize the field module name. I'm not sure what the policy is, but let's make sure it's all the same :)

+++ b/core/modules/number/config/schema/number.schema.ymlundefined
@@ -0,0 +1,127 @@
+field.number_integer.settings:
+  type: sequence
+  label: 'Integer settings'
+  sequence:
+    - type: string
+      label: 'setting'

I'm trying to figure out where this points to ? Sorry if this is a stupid question :/

One other thing I've been wondering: 'DefaultNumberFormatter' class contains settings for the formatter ('Thousand marker' and 'Display prefix and suffix'). Is that something that needs to be in the config schema as well ?

Title:Provide config schema to field types, widgets and storage in number moduleProvide config schema to field types and storage in number module
Status:Needs review» Needs work

Widget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.

Everything working fine from my side.
Good to go....

Status:Needs work» Needs review
StatusFileSize
new2.63 KB
PASSED: [[SimpleTest]]: [MySQL] 56,842 pass(es).
[ View ]

Removing widget as per #4.

StatusFileSize
new2.63 KB
PASSED: [[SimpleTest]]: [MySQL] 56,964 pass(es).
[ View ]

Please ignore the previous patch. Changed the module's name to lower case as per #3. Though I'm not sure about the 'DefaultNumberFormatter'.

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new2.35 KB
PASSED: [[SimpleTest]]: [MySQL] 57,163 pass(es).
[ View ]

I just removed the user_register_form instance setting, it's a thing from the past now that form "form modes" are in.

Other than that, looks good, thanks !

Status:Reviewed & tested by the community» Needs work
Issue tags:-Configuration system, -D8MI, -Field API, -language-config, -Configuration schema, -Field configuration schema

The last submitted patch, 1973450-config-schema-field-number-8.patch, failed testing.

Status:Needs review» Reviewed & tested by the community

Note : opened #2049485: Remove traces of the 'user_register_form' field setting to remove 'user_register_form' from the existing config entries and config schemas

Status:Reviewed & tested by the community» Fixed

Committed fc7cd79 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.