Those style are actually plugins.
Having some OOP can reduce the code complexity, and be more inline with other modules.

CommentFileSizeAuthor
#3 issued.jpg555.64 KBamitaibu
#3 summary.jpg506.9 KBamitaibu
#3 get-text.jpg179.73 KBamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

Title: Implement biblio styles as CTools plugins » Re-think Biblio in Drupal 7
Assigned: Unassigned » amitaibu
Category: feature » task
Status: Active » Needs work

For those that feel brave -- https://github.com/amitaibu/biblio/blob/overhaul/README.md :)

https://github.com/amitaibu/biblio

Very much work in progress, but for now it's a proof of concept of how we can modernize Biblio.

amitaibu’s picture

@rjerome,
Did you have a chance to look at the repo?

amitaibu’s picture

FileSize
179.73 KB
506.9 KB
555.64 KB

Views integration now shows grouping using custom fields. See Biblio-example.

issued.jpg

summary.jpg

get-text.jpg

amitaibu’s picture

wundo’s picture

Any special reason why this development is being done on GitHub and not here?

amitaibu’s picture

Github makes it easier to have a sandbox + I dont have commit access yet to Biblio :)

Anyway, reviews and help will be appreciated

amitaibu’s picture

Status: Needs work » Needs review

No patch here, but setting to needs review - as there's a lot of code (and tests) already working in https://github.com/amitaibu/biblio

@rjerome , would be great if you could have a look, so we can collaborate and join forces.

wundo’s picture

Status: Needs review » Needs work

@Amitaibu,
I've been testing your branch and found some issues, could you confirm github is the proper place to report the issues?

amitaibu’s picture

Status: Needs work » Needs review

@wundo,

Indeed, the development of Biblio 3.x is very active thanks to Harvard's OpenScholar.

I'm re-setting to needs review, not because I think the work is done, but because it's in a state where people can start testing it, provide feedback and like you did -- provide Pull requests :)

btw, Make sure you follow the short README for the installation.

gaellafond’s picture

Issue summary: View changes

@amitaibu
Thanks for this module.

I had a look at the latest version of Jerome's Biblio module for drupal 7 (version 1.0-rc7) and it is not up to our code standards. I found several cases of SQL injection, XSS, etc. They are in the admin, but I my opinion, there is no excuse for those kind of vulnerabilities.

Your version seems much better. Unfortunately, it has been inactive for over a year. Is the project dead? Did it reach a point of perfection where nothing needs to be done? Is it safe to use on a production server?

amitaibu’s picture

@gaellafond,

> Is the project dead?

Not dead, but on a long stop. OpenScholar has decided to keep the existing module, and I'd take the risk to say it will use the new architecture for D8 (when it will be ready).

At this point, only if we'll be able to find clients, we'll finish the porting.

Liam Morland’s picture

Status: Needs review » Closed (outdated)

Bibliography Module 7.x-2.x is not being developed. If this issue applies to a maintained branch, please re-open and move it to that branch.