I have attached 2 patches for testing to allow for enable/disable of retweet and replies in the twitter_pull feed.

CommentFileSizeAuthor
#6 1977950-6.twitter_pull.options-retweets-replies.patch5.77 KBjoachim
#1 enable-disable-retweet-and-replies.twitter_pull-1977850-2.patch5.82 KBcdenneen
add-dependency-on-twitter_twitter_pull.patch402 bytescdenneen
enable-disable-retweet-and-replies.twitter_pull.patch5.79 KBcdenneen

Comments

cdenneen’s picture

cdenneen commented
StatusFileSize
new enable-disable-retweet-and-replies.twitter_pull-1977850-2.patch5.82 KB

Modified variables to NULL to avoid causing warnings for undefined variables

jec006’s picture

jec006 commented
Status: Needs review » Fixed

Committed here: http://drupalcode.org/project/twitter_pull.git/commit/39b3979

thanks cdenneen

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

joachim commented
Version: 7.x-2.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)

I'd like to backport this to 6.x-1.x.

joachim’s picture

joachim commented

A patch here would depend on those at:

- #1781024: Make the Twitter Pull module work when Twitter turns off the version 1 API
- #917460: support for Boxes module

also, twitter_pull_render() has an extra parameter in D7 that was added in #1124732: Lazy load tweets [patch]. Not backporting this first would mean that twitter_pull_render() diverges between D6 and D7 -- but then currently it already does!

joachim’s picture

joachim commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1977950-6.twitter_pull.options-retweets-replies.patch5.77 KB

Here's a patch. It's cumulative on the patches at the issues mentioned above, specifically at these comments:

- https://drupal.org/node/1781024#comment-7583403
- https://drupal.org/node/917460#comment-6682336

joachim’s picture

joachim commented
Status: Needs review » Fixed

Committed to 6.x.-2.x.

Issue #1977950 by cdenneen, joachim: Added options for showing retweets and replies in Twitter Block Box.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

raulmuroc’s picture

raulmuroc commented
Issue summary: View changes

+1