'workflow_tab_form' not found

Is there a use case for a single step workflow?

Hi Nancy,

I get the same error:
Notice: Undefined property: stdClass::$workflow in workflow_node_update() (line 240 of .../workflow/workflow.module).

However in my case, I have 6 steps shared across three roles, that is 2 steps in each role.
The error happens whenever I update a node contributing in the workflow.

Any idea what could be the cause of that issue ?

Thank you

Drupal v7.22
Workflow 7.x-1.1
Workflow Content Permissions 7.x-1.0

Hi Nancy,

I get the same error:
Notice: Undefined property: stdClass::$workflow in workflow_node_update() (line 240 of .../workflow/workflow.module).

However in my case, I have 6 steps shared across three roles, that is 2 steps in each role.
The error happens whenever I update a node contributing in the workflow.

Any idea what could be the cause of that issue ?

Thank you

Drupal v7.22
Workflow 7.x-1.1
Workflow Content Permissions 7.x-1.0

I did find a small issue with workflow_node_load(), so it may be fixed shortly.

Please download the latest dev code and see if this is still an issue.

I installed the Dev code and ran the database update. I'm no longer getting the "Notice : Undefined property:" but now I'm getting the messages below on every node page.

Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'workflow_tab_form' not found in drupal_retrieve_form() (line 798 of C:\Program Files (x86)\EasyPHP-12.0\www\aapi\includes\form.inc).
    Notice: Array to string conversion in drupal_prepare_form() (line 1048 of C:\Program Files (x86)\EasyPHP-12.0\www\aapi\includes\form.inc).
    Notice: Array to string conversion in drupal_prepare_form() (line 1062 of C:\Program Files (x86)\EasyPHP-12.0\www\aapi\includes\form.inc).
    Notice: Array to string conversion in drupal_prepare_form() (line 1082 of C:\Program Files (x86)\EasyPHP-12.0\www\aapi\includes\form.inc).

What is "EasyPHP-12.0"?

I am not seeing this on my test site.

It's my WAMP server. http://www.easyphp.org/

the webroot starts after aapi\

Are you getting the Workflow tab?

Yes, I'm getting the Workflow tab.

But not the state change form on the node view? Do you have any other workflow-related modules?

I'm running Workflow Extensions 7.x-1.0-beta3, which I'm using to replace the standard state change form with a block.

Update:

I updated to the Dev build from 5/16 and still got the same errors from #7, so then I disabled Workflow Extensions and I no longer get the errors.

My client really prefers the buttons from Workflow Extensions, so disabling really isn't an option for me. Any suggestions on where to look from here?

I work fairly closely with Rik and we've dealt with this. Are you using his latest code? I'm using 7.x-1.0-beta3 of Workflow Extensions.

I am now seeing this is a site that has a complicated workflow. I am beginning to it's in the Workflow Extensions "Change Workflow State" block. Are you using that?

Yes, I'm on 7.x-1.0-beta3 of Workflow Extensions and am using the "Change Workflow State" block.

Just out of curiosity, which Drupal and PHP versions?

Moving to Workflow Extensions.

Rik: I removed workflow_extensions_forms() and this issue disappeared. Prior to that, the form themes were seeing an array rather than a string. I'm guessing it's because both WE and Workflow had hook_forms() implementations.

If you want to be flexible, then this should do it:

function workflow_extensions_forms($form_id, $args) {
  if (function_exists('workflow_forms')) {
    return array();
  }
  if (strpos($form_id, 'workflow_tab_form_nid') === 0) {

The Workflow patch is applied.

I'm seeing this error and am using the latest -dev versions of workflow and workflow_extensions. I'll see if I can debug.

I'm onto something... I see there are two workflow_tab_form items in the callback and if I remove one (hack) then it renders and the errors are gone. I'll see if I can figure out why there are two in there.

If I comment out the form definition here:

function workflow_extensions_forms($form_id, $args) {
  /*
  if (strpos($form_id, 'workflow_tab_form_nid') === 0) {
    $form = array(
      $form_id => array(
        'callback' => 'workflow_tab_form',
        'callback arguments' => array(),
      ),
    );
    return $form;
  }
  */
}

Then there error is gone and the workflow state form shows up in my view. But, when I click one of the transition buttons from within the views UI, I get some ajax errors. But, if I use it directly from the regular page (where the view shows up), then it works fine.

Perhaps there is a better way to remove the duplicate and maybe this form registration is needed for other things? I've included a patch that removes this function entirely but I'm not sure that is the best approach.

Kristen, I was getting that until I did #19.

Der... I misunderstood and thought that #20 meant that dev was updated with all changes from #19... I guess I should have read it more carefully!!!! :/ I can roll a patch with your change.

Here's a patch with changes from @NancyDru... ready for testing. It works great for me.

Patch from #20/#27 applied with attribution to Nancy.
Available in the next dev snapshot 7.x-1.x-dev.
Thanks Kristen for reaching the same conclusion and for testing.
Rik

Thanks for committing so quickly! :)

Thanks, Rik.

Pleasure, Nancy.
I may call this version 7.x-1.0-beta4.
I still haven't done the tokens for us on the buttons. It may have to be a stable but incomplete release... just very busy at the mo.
Rik

Thanks to Rik, Nancy and Kristen. This was a big help.