Hello maintainers.

Thanks for the great work on this module. I noticed that there is a dependency on Composer Autoload, but I wondered if you would explore integrating with Composer Manager as well? The main advantage is that it allows module to place all third party dependencies in a single location and use the same autoloader so that maintenance is easier and the possibility of duplicate packages is eliminated.

For example, if you used this module in tandem with Git Wrapper and the Composer Autoload technique was used, you would actually have two duplicate installs of Symfony's Event Dispatcher component. Which one is called depends on which autoloader is registered first in the application.

Anyways, I just wanted to throw this suggestion out there.

Thanks,
Chris

CommentFileSizeAuthor
#5 guzzle-1979822-5.patch1.2 KBcorvus_ch
#2 1979822-composer-manager-integration.patch266 bytestayzlor

Comments

andyhu’s picture

andyhu commented

+1 for this

tayzlor’s picture

tayzlor commented
StatusFileSize
new 1979822-composer-manager-integration.patch266 bytes

Here's a patch that adds that integration, everything else should just fall out through the composer_manager module. Note, you might need this patch with the current latest stable of composer_manager - https://drupal.org/node/2059371#comment-7727767

tayzlor’s picture

tayzlor commented
Status: Active » Needs review
tsphethean’s picture

tsphethean commented
Status: Needs review » Reviewed & tested by the community

Works for me!

corvus_ch’s picture

corvus_ch commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new guzzle-1979822-5.patch1.2 KB

A different approach would be to do not add a dependency to either composer_manager or composer_autoload and leave it ti the developer to decide which solution to choose.

cpliakas’s picture

cpliakas commented

+1. I like that approach.

cpliakas’s picture

cpliakas commented
Issue summary: View changes

Just as an FYI, we are discussing potentially rolling a Guzzle integration module into the Composer Manager codebase since there are some challenges with D8's adoption of Composer. See #2128353-31: D8 strategy for Composer Manager for more details.

cpliakas’s picture

cpliakas commented
Related issues: +#2128353: D8 strategy for Composer Manager
cpliakas’s picture

cpliakas commented
Status: Needs review » Closed (fixed)

Closing as fixed, since this project has been deprecated in favor of Composer Manager as noted on the project page.