If you clone a message type, the fields are not cloned.

Classifying as a bug report, since it's contrary to user expectations, and frequently surfaces both in the Commerce Message issue queue, and internally.
Patch to follow.

CommentFileSizeAuthor
#1 1983138-clone-field-instances-1.patch1.45 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Active » Needs review
FileSize
1983138-clone-field-instances-1.patch1.45 KB

Here we go.

The menu_get_object call is a bit ugly, but there's no other way to get the entity that's being cloned.
I could also go with storing just the original message type name in the form state.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Needs review » Fixed

The menu_get_object() is indeed a little ugly, but if in the future we will want the full object, better get it in already.

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.