Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marvil07’s picture

Assigned: Unassigned » marvil07
Status: Active » Needs review
FileSize
18.11 KB

A new version of the patch after changes related with default branch on git_default reposync plugin. This still needs work, but NR for testbot.

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-1985426-Implement-versioncontrol-reposync-plug.patch, failed testing.

marvil07’s picture

Uhm, bot is failing because it is using last release of versioncontrol instead of the dev version tarball, I added a new release on versiocontrol, but not sure how often testbot notices new releases. Let's wait a little, or if someone knows how to let bot use dev tarball please tell me :-)

marvil07’s picture

Status: Needs work » Needs review
FileSize
18.59 KB

let's try adding a version requirement on dependencies array at info file

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-1985426-Implement-versioncontrol-reposync-plug.patch, failed testing.

marvil07’s picture

There was a bug on versioncontrol about sync options, it's now fixed, and now tests are passing locally.

I also changed versioncontrol_git dependency to use versioncontrol 7.x-1.x-dev, hopefully that will make testbot choose the dev tarball, but I will wait to re-test until next rebuild of dev tarballs and until the next project dependencies rebuild, but I think the patch as it is now(comment 1 patch) will go into upstream soon.

marvil07’s picture

Status: Needs work » Needs review
marvil07’s picture

Ok, I give up with both, it postponed the patch because a current 7.x-1.x branch here needs a patch to avoid a fatal because of signature change. I run tests locally and it worked correctly, so adding the attached patches.

marvil07’s picture

Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Needs work

Now NW for D6 version.

marvil07’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs work » Fixed
Issue tags: -Needs backport to D6, -versioncontrol_git-6.x-2.0-release-blocker

Since 6.x-2.x entered in maintenance mode, this will not make it there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 15ae559 on 7.x-1.x, fix-invalid-default-branches, fullsync-memory by marvil07:
    Issue #1985426: Implement versioncontrol reposync plugin option to store...
  • Commit e78ce92 on 7.x-1.x, fix-invalid-default-branches, fullsync-memory by marvil07:
    Issue #1985426 follow-up: Use class constants to define test repository...