Issue Summary can be found in this gist: https://gist.github.com/steinmb/5632073

Problem/Motivation

The Twig team has decided to focus on .tpl.php to .html.twig conversions for the immediate future, with the goal of getting these conversions committed before or at DrupalCon Portland. As a result, some of our existing conversion issues will need to be split up and the .tpl.php conversions and related preprocess changes moved to the new issues.

This will be the first Twig conversion patch to get into core, solely focused on *.tpl.php. Conversion of concatenation-based theme_ functions is a desired secondary step, but is lower priority than all work below.

Current status

We're ready to run profiling on the issues listed below under Remaining tasks. See the Contributor profiling instructions for more information.

Finished tasks

These issues have converted all tpl.php files within their scope to html.twig, are well documented, been manually tested for HTML inconsistencies, are performant with proof and have been verified by a core maintainer.

Files: 
CommentFileSizeAuthor
#34 1987510-34.patch357.69 KBCottser
PASSED: [[SimpleTest]]: [MySQL] 56,059 pass(es).
[ View ]
#34 interdiff.txt37.54 KBCottser
#23 interdiff.txt1.11 KBjoelpittet
#23 1987510-22-tpl-files.patch353.1 KBjoelpittet
PASSED: [[SimpleTest]]: [MySQL] 55,654 pass(es).
[ View ]
#19 1987510-18.patch352.46 KBCottser
FAILED: [[SimpleTest]]: [MySQL] 55,833 pass(es), 1 fail(s), and 1 exception(s).
[ View ]
#17 1987510-17.patch390.93 KBCottser
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1987510-17.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 twig-conversion-megapatch-v1.patch310.13 KBFabianx
PASSED: [[SimpleTest]]: [MySQL] 55,369 pass(es).
[ View ]

Comments

Priority:Normal» Critical

Looks like this one should be critical.

Title:[meta] Convert core PHPTemplate template files to Twig[meta] (in transition) Convert core PHPTemplate template files to Twig
Priority:Critical» Normal

I understand the intention of this issue but given the momentum of the existing conversion issues, I've argued that those are better for the template-based conversions and these new ones should be for the theme_-function based conversions.

I'm going to be revising these titles. I'm not we need a separate meta here the only justification was "too big." @jenlampton, can you clarify how "too big" is worse than "two meta issues?"

Title:[meta] (in transition) Convert core PHPTemplate template files to Twig[meta] (in transition) Convert core theme_ functions to Twig

Retitling per #2

Issue summary:View changes

Remove unneeded sentence from first paragraph

Priority:Normal» Major

Revising priority for now.

The intention of creating this issue was to prevent 1757550 from getting closed when "the patch" went in. "The patch" being the one with all the .tpl.php conversions bundled together. This issue was meant to be the one that got closed.

Title:[meta] (in transition) Convert core theme_ functions to Twig[meta] Convert all core tpl.php functions to Twig
Priority:Major» Critical

retitling to that end. Also, still critical.

Issue summary:View changes

Revise issues list

Issue summary:View changes

remove theme conversions

Issue summary:View changes

links to conversions

Title:[meta] Convert all core tpl.php functions to Twig[meta] Convert all core *.tpl.php templates to Twig as singular patch

Clarifying title. @Fabianx has volunteered to combine patches above once they are at least "needs review" (and hopefully RTBC).

Issue summary:View changes

benchmarking, bold

Status:Active» Needs review
StatusFileSize
new310.13 KB
PASSED: [[SimpleTest]]: [MySQL] 55,369 pass(es).
[ View ]

And here is the twig mega patch, this still needs the patch included to remove double engine support and add twig as default engine.

It is proposed to review individual issues, but this patch is the overall whole package.

( This was build automatically from: https://github.com/LionsAd/twig-in-core-megapatch/branches )

Lets see what testbot thinks :).

Issue summary:View changes

Updated issue summary.

Issue tags:+Needs profiling

We're doing the profiling against the "mega patch" now, right?

We can probably start doing that now if we want.

AFAICS almost everything that is "needs work" is documentation only and the majority of "needs review" is primarily waiting on manual testing rather than feedback on how the code will be structured.

Issue summary:View changes

trigger update

Issue summary:View changes

trigger update

1 month left! We've got 32 more patches to get [READY]. We need to average knocking off more than one every day now.

If you want to help, the main tasks left are Manual testing and Profiling. If you don't know how to do either then join #drupal-twig in IRC and ask. There's almost always someone in IRC who can help explain how we want Manual testing done and @Fabianx and @Cottser have been doing most of the profiling so far so they're the ones to talk to for that.

Issue summary:View changes

update again

Issue summary:View changes

Add default theme engine issue

Profiling is indeed our largest remaining task for .tpl.php conversion. Not sure where else to post this, so here goes.

Here is what I know so far in regards to Twig profiling, from what @Fabianx has taught me and my experience so far:

Most of us have been using @Fabianx’s xhprof-kit, please find installation instructions there. I recommend installing Drush 6.x and registry rebuild.

I’ve also been using these functions and aliases along with xhprof-kit, and these are used in the instructions below:
https://gist.github.com/Cottser/5588734

To be able to upload runs for others to see, ping @Fabianx on IRC for an API key.

Recommended profiling workflow

  • Always use the Stark theme (so that node.html.twig is used) and enable the APC class loader in settings.php.
  • Create a new branch from 8.x to test the patch in question, e.g. user-1898468-91 and commit the Twig conversion patch there.
  • Set up your scenario so that it can be seen by anonymous users on the homepage. Example: if you’re testing the user.tpl.php conversion, allow anonymous users to view user profiles and set the homepage to user/1.

Isolate profiling to only the current conversion

To isolate the profiling to only the conversion at hand in cases where there are no nodes on the page, I recommend doing one of two things (the entity reference method takes a bit longer to set up but you may have more stable numbers using that method):

First, create a sample node.

Method one - Views:

  • Create a new view with a block display using the default settings (admin/structure/views/add).
  • Place the new views block somewhere on the page (admin/structure/block/list/block_plugin_ui%3Astark/add).

Method two - Entity Reference:

  • Create a custom block type with an entity reference field (admin/structure/custom-blocks/add)
  • Go to ‘Manage Display’ for the new custom block type and set it to display ‘rendered entity’, ‘full content’.
  • Create a custom block referencing the sample node (block/add).
  • Place the new custom block somewhere on the page (admin/structure/block/list/block_plugin_ui%3Astark/add).

Run profiling

To continue with the example of user.tpl.php profiling, we have a user-1898468-91 branch with the Twig conversion committed to it and the scenario is set up so that anonymous users can view it on the homepage (with Stark theme and a node being rendered somewhere on the page). Once all that is in place I will:

  • Switch to 8.x: git checkout 8.x

  • Run bbranch, you should get output like this:

    loop time: |0.345511s|51978cc86c728|drupal-perf|8.x|<a href="http://d8prof.dev/xhprof-kit/xhprof/xhprof_html/index.php?source=drupal-perf&url=%2F&run=51978cc86c728&extra=8.x" target="_blank">Profiler output</a>

  • Copy the XHProf run ID from bbranch, e.g. 51978cc86c728

  • Run bbranches 51978cc86c728 user-1898468-91 to compare your current branch (8.x) against the Twig conversion branch.

Once that finishes running you should have something like this:

=== 8.x..8.x compared (51978cc86c728..51978d2b1f3d1):
ct  : 33,570|33,570|0|0.0%
wt  : 345,567|345,166|-401|-0.1%
cpu : 315,116|314,178|-938|-0.3%
mu  : 30,324,000|30,324,000|0|0.0%
pmu : 30,433,448|30,433,448|0|0.0%
<a href="http://d8prof.dev/xhprof-kit/xhprof/xhprof_html/index.php?source=drupal-perf&url=%2F&run1=51978cc86c728&run2=51978d2b1f3d1&extra=8.x..8.x">Profiler output</a>
=== 8.x..user-1898468-91 compared (51978cc86c728..51978d4d92dd9):
ct  : 33,570|33,703|133|0.4%
wt  : 345,567|345,816|249|0.1%
cpu : 315,116|314,995|-121|-0.0%
mu  : 30,324,000|30,345,720|21,720|0.1%
pmu : 30,433,448|30,456,824|23,376|0.1%
<a href="http://d8prof.dev/xhprof-kit/xhprof/xhprof_html/index.php?source=drupal-perf&url=%2F&run1=51978cc86c728&run2=51978d4d92dd9&extra=8.x..user-1898468-91">Profiler output</a>

For the first 8.x..8.x comparison we don’t want the wt to fluctuate much at all - that is our baseline comparison to show that the first run (from bbranch) is still accurate, because that is what is being used to compare against these two new runs. You may have to go through this process (run bbranch, get run ID, run bbranches with new run ID) a few times to get a low wt fluctuation, we generally want something under +-0.5% but less is better. Don't waste all day trying to get a 0% fluctuation though :)

Post results

Once you have a comparison you’re happy with, (and you have an API key from @Fabianx) you can run:

ubench 51978cc86c728

Where 51978cc86c728 is the baseline run used for comparing, originally from bbranch.

Then you'll get something like this:

Run 51978cc86c728 uploaded successfully for drupal-perf-cottser.
Run 51978d2b1f3d1 uploaded successfully for drupal-perf-cottser.
=== 8.x..8.x compared (51978cc86c728..51978d2b1f3d1):
ct  : 33,570|33,570|0|0.0%
wt  : 345,567|345,166|-401|-0.1%
cpu : 315,116|314,178|-938|-0.3%
mu  : 30,324,000|30,324,000|0|0.0%
pmu : 30,433,448|30,433,448|0|0.0%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=51978cc86c728&run2=51978d2b1f3d1&source=drupal-perf-cottser&extra=8.x..8.x
Run 51978cc86c728 uploaded successfully for drupal-perf-cottser.
Run 51978d4d92dd9 uploaded successfully for drupal-perf-cottser.
=== 8.x..user-1898468-91 compared (51978cc86c728..51978d4d92dd9):
ct  : 33,570|33,703|133|0.4%
wt  : 345,567|345,816|249|0.1%
cpu : 315,116|314,995|-121|-0.0%
mu  : 30,324,000|30,345,720|21,720|0.1%
pmu : 30,433,448|30,456,824|23,376|0.1%
http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=51978cc86c728&run2=51978d4d92dd9&source=drupal-perf-cottser&extra=8.x..user-1898468-91

I take out the 'Run [foo] uploaded successfully' bits, wrap the comparison chunks in <code> tags, and post.

Issue summary:View changes

Added link to twig best practices doc.

Issue summary:View changes

Updated issue summary to have a "finished" section

Issue summary:View changes

Updated issue summary to have a "hopefully finished" section

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Great work by everyone in the past few days, only 24 patches left that need profiling and/or manual testing!

The manual testing is mostly complete but we still need a lot of help profiling. AFAICS every single sub-task of the Views module is now "complete" but is just waiting on performance testing. If we can power through those (and nothing unexpected pops up) we'll be looking really good for the June 17 deadline :)

Thanks for the awesome issue summary rearrangement @thedavidmeister. Let's move those issues on up! We got tons of people ready to do profiling today.

I just added branch completion to the xhprof-kit aliases/functions, enjoy: https://gist.github.com/Cottser/5588734

Edit: Also, if you are setting up xhprof-kit and are not getting any output, be sure to edit find-min-web.sh to point to your Drupal 8 install! (Change 127.0.0.1 if necessary).

Issue summary:View changes

Updated issue summary.

I just checked. Nothing is left with the manual testing tag and nothing is set to "needs work". Theoretically all that's left is the profiling.

Moving and rewriting docs on #11 over at Contributor Profiling Instructions

Please update or let me know if you have some issues.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

rtbap

Issue summary:View changes

Movin' on up!

Issue summary:View changes

Move aggregator back for re-profiling

Issue summary:View changes

More moving up :D

Issue summary:View changes

move up

Issue summary:View changes

ready

Issue summary:View changes

Link to profiling instructions

Issue summary:View changes

Move views-view-rss up

Issue summary:View changes

Move up

Issue summary:View changes

Moving up!

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

StatusFileSize
new390.93 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1987510-17.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I watched @Fabianx roll this new megapatch. This is a multipatch formatted patch for easier reviewing.

Also includes #1806478: Make twig the default engine once all modules templates are converted from .tpl.php to .html.twig and excludes #1898458: theme_test.module - Convert PHPTemplate templates to Twig.

Status:Needs review» Needs work

The last submitted patch, 1987510-17.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new352.46 KB
FAILED: [[SimpleTest]]: [MySQL] 55,833 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

Multipatch seems like it might not work. Here is a normal patch.

Patch is coming from https://github.com/Cottser/twig-in-core-megapatch

Issue summary:View changes

moved aggregator to alexpott's area

Status:Needs review» Needs work

The last submitted patch, 1987510-18.patch, failed testing.

Issue summary:View changes

moving items for fabian.

Issue summary:View changes

moved views-view to be alexpotted

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Looks like I missed something small in the double engine patch, I will update there and try to roll a new megapatch at some point today. I also will be adding some automated tests so that we ensure PHPTemplate themes still work as expected.

There are also a couple patches that conflicted unnecessarily so I will either remove those changes or mark them as novice tasks to do so :)

Just a reminder once we have all the individual patches profiled and [READY], we will do some more profiling on this megapatch for some basic scenarios, exact scenarios TBD but a node page with 50 comments would be a start.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Moving ready issues to ready category

Issue summary:View changes

Changing fabianx's name to use lowercase

Issue summary:View changes

Moved #1843750 to finished/unverified pile.

Issue summary:View changes

Move a couple more issues to "finished"

Issue summary:View changes

Moved #1843752 to finished/unverified.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

just 10 general profiling tasks left :)

Issue summary:View changes

Moved #1843764 to finished/unverified.

Issue summary:View changes

Updated issue summary.

Status:Needs work» Needs review
StatusFileSize
new353.1 KB
PASSED: [[SimpleTest]]: [MySQL] 55,654 pass(es).
[ View ]
new1.11 KB

Same as #19 with the ThemeTest.php using twig instead of php template.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Moving #1843748 to finished/unverified

Issue summary:View changes

moved block back to tasks

Thanks @joelpittet, green again!


New Twig contributor task available:

We need help giving everyone who has worked on these issues credit - in the form of commit mentions. At this point I think we are not totally sure whether the patches will get committed individually in their own issues or all at once as a 'megapatch'.

Either way, I think we can update the issue summaries on each sub-issue to include/update a commit message with the names of everyone who worked on the issues. Some sub-issues (example: #1898460: taxonomy.module - Convert PHPTemplate templates to Twig) have a commit message already at the top but those are probably very outdated.

Can one or more people take on this task? The sooner the better :)

Hint: If you install Dreditor you will get a 'Create commit message' on the comment form that will help pull in people who have worked on patches. Although IMO we should be crediting all the hardworking profilers as well!

Issue summary:View changes

Moving 1843762 to alexpott's queue.

I second crediting the profilers. ^^

Issue summary:View changes

Move up views-view-field

Issue summary:View changes

Move up layout

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Move views-view-fields down to Fabian section

#23: 1987510-22-tpl-files.patch queued for re-testing.

Issue summary:View changes

Move up up up

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Added #1898474 to finished/unverified

Issue summary:View changes

Move Fabian issues back for re-profiling

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Moving another issue up

Issue summary:View changes

Removing pager.inc from this issue - it does not belong here, please do not add theme function conversions to this meta.

Issue summary:View changes

Move forum up

Issue summary:View changes

Move up system

Issue summary:View changes

Move up bartik

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Move block up to alexpott section

Issue summary:View changes

Move up then sleep

Issue summary:View changes

move DEC to alexpott

Issue summary:View changes

Added performance followups section with first issue.

Issue summary:View changes

Added #2002104 to performance followups

Issue summary:View changes

Added #2002108 to performance followups

These 4 scenarios

Using stark theme:

  1. Standard frontpage view with 10 nodes
  2. Node Page with 50 comments
  3. User Profile Page
  4. Maintenance Page

Issue summary:View changes

Updated issue summary.

I can take scenario 1: Standard frontpage view with 10 nodes.

Issue summary:View changes

Added #2002222 to performance followups

Scenario 1 with Stark.

=== 8.x..8.x compared (519ead70538d1..519eadc55e057):
ct  : 140,633|140,633|0|0.0%
wt  : 921,429|922,742|1,313|0.1%
cpu : 850,689|850,923|234|0.0%
mu  : 9,571,892|9,571,892|0|0.0%
pmu : 9,873,260|9,873,260|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ead70538d1&...
=== 8.x..megapatch compared (519ead70538d1..519eae2ae63ab):
ct  : 140,633|141,579|946|0.7%
wt  : 921,429|920,521|-908|-0.1%
cpu : 850,689|850,525|-164|-0.0%
mu  : 9,571,892|9,804,824|232,932|2.4%
pmu : 9,873,260|10,029,560|156,300|1.6%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ead70538d1&...

Scenario 1

10 nodes in Stark

=== 8.x..8.x compared (519ead03a5283..519eada161e65):
ct  : 80,951|80,951|0|0.0%
wt  : 359,176|359,059|-117|-0.0%
cpu : 319,498|317,542|-1,956|-0.6%
mu  : 14,904,072|14,904,072|0|0.0%
pmu : 15,120,880|15,120,880|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ead03a5283&...

=== 8.x..1987510-tpl-files compared (519ead03a5283..519eade6f30be):
ct  : 80,951|81,315|364|0.4%
wt  : 359,176|361,866|2,690|0.7%
cpu : 319,498|318,292|-1,206|-0.4%
mu  : 14,904,072|15,205,904|301,832|2.0%
pmu : 15,120,880|15,408,344|287,464|1.9%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ead03a5283&...

10 nodes in Bartik

=== 8.x..8.x compared (519eb193b2faa..519eb1c65e7e6):
ct  : 87,078|87,078|0|0.0%
wt  : 384,824|383,261|-1,563|-0.4%
cpu : 338,153|340,791|2,638|0.8%
mu  : 15,002,792|15,002,792|0|0.0%
pmu : 15,227,736|15,227,736|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb193b2faa&...

=== 8.x..1987510-tpl-files compared (519eb193b2faa..519eb20dce0a3):
ct  : 87,078|89,081|2,003|2.3%
wt  : 384,824|393,650|8,826|2.3%
cpu : 338,153|353,452|15,299|4.5%
mu  : 15,002,792|15,771,264|768,472|5.1%
pmu : 15,227,736|15,983,488|755,752|5.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb193b2faa&...

Issue summary:View changes

Added performance follow-up.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Move up alexpotted issues :)

Issue summary:View changes

Updated issue summary.

Scenario 3 with Stark.

=== 8.x..8.x compared (519eb486908e7..519eb5243677d):
ct  : 140,633|140,633|0|0.0%
wt  : 938,462|940,417|1,955|0.2%
cpu : 864,463|865,468|1,005|0.1%
mu  : 9,701,264|9,701,264|0|0.0%
pmu : 10,002,912|10,002,912|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb486908e7&...
=== 8.x..megapatch compared (519eb486908e7..519eb57e9174a):
ct  : 140,633|141,579|946|0.7%
wt  : 938,462|936,706|-1,756|-0.2%
cpu : 864,463|866,387|1,924|0.2%
mu  : 9,701,264|9,934,248|232,984|2.4%
pmu : 10,002,912|10,158,948|156,036|1.6%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb486908e7&...

Scenario 3 with Bartik. This is really weird, the function call number and memory usage is exactly the same as S3 with Stark. I'm quite sure I was using Bartik for this run.

=== 8.x..8.x compared (519eb7a1537f7..519eb7f35533b):
ct  : 140,633|140,633|0|0.0%
wt  : 957,508|954,584|-2,924|-0.3%
cpu : 883,247|881,721|-1,526|-0.2%
mu  : 9,701,264|9,701,264|0|0.0%
pmu : 10,002,912|10,002,912|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb7a1537f7&...
=== 8.x..megapatch compared (519eb7a1537f7..519eb880e5974):
ct  : 140,633|141,579|946|0.7%
wt  : 957,508|953,923|-3,585|-0.4%
cpu : 883,247|883,144|-103|-0.0%
mu  : 9,701,264|9,934,248|232,984|2.4%
pmu : 10,002,912|10,158,948|156,036|1.6%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519eb7a1537f7&...

Scenario 2

50 threaded comments on a node in Bartik

=== 8.x..8.x compared (519ec8682c2dc..519ec8bd1b3c1):
ct  : 237,484|237,484|0|0.0%
wt  : 821,304|818,724|-2,580|-0.3%
cpu : 780,563|785,150|4,587|0.6%
mu  : 15,052,656|15,052,656|0|0.0%
pmu : 15,730,536|15,730,536|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ec8682c2dc&...

=== 8.x..1987510-tpl-files compared (519ec8682c2dc..519ec94fa4daa):
ct  : 237,484|246,607|9,123|3.8%
wt  : 821,304|854,447|33,143|4.0%
cpu : 780,563|821,561|40,998|5.3%
mu  : 15,052,656|15,777,480|724,824|4.8%
pmu : 15,730,536|16,395,720|665,184|4.2%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ec8682c2dc&...

50 flat comments on a node in Stark

=== 8.x..8.x compared (519ede3a9dd65..519edeb20e5f1):
ct  : 198,325|198,325|0|0.0%
wt  : 716,862|716,580|-282|-0.0%
cpu : 678,273|676,516|-1,757|-0.3%
mu  : 15,330,872|15,330,872|0|0.0%
pmu : 15,821,912|15,821,912|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ede3a9dd65&...

=== 8.x..1987510-tpl-files compared (519ede3a9dd65..519edf3566aae):
ct  : 198,325|206,178|7,853|4.0%
wt  : 716,862|742,586|25,724|3.6%
cpu : 678,273|706,714|28,441|4.2%
mu  : 15,330,872|15,610,824|279,952|1.8%
pmu : 15,821,912|15,960,128|138,216|0.9%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519ede3a9dd65&...

StatusFileSize
new37.54 KB
new357.69 KB
PASSED: [[SimpleTest]]: [MySQL] 56,059 pass(es).
[ View ]

Numbers are looking good for profiling, no real surprises. Yes comment is a bit slow but we have #2002094: Improve performance of comment.html.twig.

Here is a new megapatch with the recent changes from the sub-issues here.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes

Moved patches up to alex section

Scenario 4

Maintenance Page (using Stark theme)

=== 8.x..8.x compared (519fbf2154a5e..519fc26fe04d9):
ct  : 6,008|6,008|0|0.0%
wt  : 34,299|34,146|-153|-0.4%
cpu : 32,003|32,002|-1|-0.0%
mu  : 2,866,440|2,866,440|0|0.0%
pmu : 2,877,476|2,877,476|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519fbf2154a5e&...

=== 8.x..1987510-twig-mega-patch compared (519fbf2154a5e..519fc2983e6a9):
ct  : 6,008|6,283|275|4.6%
wt  : 34,299|35,304|1,005|2.9%
cpu : 32,003|32,001|-2|-0.0%
mu  : 2,866,440|3,084,204|217,764|7.6%
pmu : 2,877,476|3,094,948|217,472|7.6%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=519fbf2154a5e&...

Status:Needs review» Fixed

All template conversion patches have been committed. This issue is closed. :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

x