Convert ajax_test_dialog_contents() to a new style controller

I'll help!

This appears to be already done in commit 22df596! :D

Let's see...

Patch #6 doesn't apply any more. Attaching an equivalent patch that applies to latest HEAD.

Reroll.

There were 2 reasons for failing tests:

1. \Drupal\ajax_test\Controller\AjaxTestController::dialogContents() must be declared as static
2. Removed function ajax_test_dialog_contents() was called from AjaxTestDialogForm::dialog()

Both fixed, see attached patch

Hello!

Thank you for working on this issue!

We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.

+++ b/core/modules/system/tests/modules/ajax_test/src/Controller/AjaxTestController.php
@@ -17,9 +17,26 @@ class AjaxTestController {
   /**
    * Returns example content for dialog testing.
    */
-  public function dialogContents() {
-    // Re-use the utility method that returns the example content.
-    return ajax_test_dialog_contents();
+  public static function dialogContents() {

Add @return to the docblock, please. https://www.drupal.org/coding-standards/docs#return

Added @return to docblock per #17

+++ b/core/modules/system/tests/modules/ajax_test/src/Controller/AjaxTestController.php
@@ -15,11 +15,30 @@
   /**
-   * Returns example content for dialog testing.
+   * Example content for dialog testing.
+   * @return array
+   *   Renderable array of AJAX dialog contents.
    */
-  public function dialogContents() {

Thanks... But now there has to be an empty line before the @return annotation. :-)

So like this:

  /**
   * Example content for dialog testing.
   *
   * @return array
   *   Renderable array of AJAX dialog contents.
   */

Here we go!

Removed extra space in separator comment line

Diggit. :-)

Refactors ajax_test_dialog_contents() into AjaxTestController::dialogContents().

git ac https://www.drupal.org/files/issues/1987612-21.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4012  100  4012    0     0  45828      0 --:--:-- --:--:-- --:--:-- 47200
error: patch failed: core/modules/system/tests/modules/ajax_test/src/Form/AjaxTestDialogForm.php:97
error: core/modules/system/tests/modules/ajax_test/src/Form/AjaxTestDialogForm.php: patch does not apply

I just rerolled this one. ANd triple checked my reroll was complete.

Looks good!

RTBC++

Committed fa9e185 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.