Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
system.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
6 May 2013 at 08:53 UTC
Updated:
29 Jul 2014 at 22:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr commentedComment #3
disasm commentedComment #4
disasm commentedComment #5
disasm commentedattached patch converts all routes in error_test module and fixes the error messages the tests are looking for.
Comment #7
disasm commentedattached patch with interdiff fixes remaining test failures.
Comment #8
dawehnerLet's simply extend the ControllerBase, so need for this boilerplate for tests.
Comment #9
disasm commentedrenamed Controllers -> Controller.
Removed boilerplate in favor of $this->container->get
Comment #11
disasm commentedAttached patch fixes missing ;
Comment #13
disasm commentedForgot error handlers were keying off of the class name. That's fixed too now.
Comment #14
disasm commentedComment #15
dawehnerLet's remove that :)
Comment #16
disasm commentedremoved!
Comment #17
jibranThere is one more.
Comment #18
disasm commentedremoved!
Comment #19
Crell commentedQuick, before core changes again. :-)
Comment #20
Crell commented#18: drupal8.error_test.1987700-18.patch queued for re-testing.
Comment #21
webchickCommitted and pushed to 8.x. Thanks!