Closed (fixed)
Project:
Backstretch
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 May 2013 at 17:36 UTC
Updated:
19 Jun 2013 at 11:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
yannickooOh sorry, that happened if the value is zero, fixed with c807887.
The other suggestion is related to this issue #1977740: Suggestion: Expose duration and fade config even if field is not multiple value.
Comment #2
juliusvaart commentedThanks yannickoo.
Great work on this module and the quick issue response!
Comment #4
jeni_dc commentedI'm changing this to needs review since the same problem was happening with the context integration. I've attached a patch that fixes this, which is just the same fix from the patch mentioned above.
Comment #5
guy_schneerson commentedmanaged to recreate the issue by installing the module & creating a context that activates backstretch and got the error.
The patch in #4 fixed the issue.
Comment #6
yannickooCool, thank you jeni_dc, fixed with c178a85. You should name the patch correctly. See Submitting patches:
Comment #7
guy_schneerson commentedHi yannickoo Was wondering about the state of the patch naming. I have been following the instructions on the project version control page https://drupal.org/project/backstretch/git-instructions although I think adding the module name is better.
do you know which of the two is more up to date?
Comment #8
yannickooOh, good to know.
I will post an issueI posted an issue (#2012538: "Creating a patch" section on the "Version control" page) in the Drupal.org webmasters issue queue. Please use the module name as prefix in the patch name :)Comment #9
guy_schneerson commentednice one yannickoo :)