Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If enabled it shows "true" or "false" as first item in the select list. Depends on "Show header instead of the active item" setting.
Both looks totally wrong to me. I expect - Please select -
Comment | File | Size | Author |
---|
Comments
Comment #1
hass CreditAttribution: hass commentedFor me it looks the like header is not detected. This is visible as the header is still shown. Should it removed or moved into the selectbox? I know I have a custom menu block. HTML is not like standard core (themed).
Comment #2
hass CreditAttribution: hass commentedThis happens if you use tinynav 1.1.
Comment #3
Hanpersand CreditAttribution: Hanpersand commentedThis is happening for me, too, and I'm not using the dev branch of the module. I'm using version 1.2. The first item is "True" or "False".
I got the library from its GitHub page here: https://github.com/viljamis/TinyNav.js
Is there a fix for this?
I'm also using a custom menu block, but it's not a dropdown. Just a simple, single-level menu block.
Thank you!
Comment #4
hass CreditAttribution: hass commentedComment #5
btopro CreditAttribution: btopro commentedTry using the fall-back library instead of the github installed libraries one. See if that helps at least in narrowing things down
Comment #6
Hanpersand CreditAttribution: Hanpersand commentedAh, yes. That totally worked. I deleted the tinynav library from sites/all/libraries, and it fell back to the drupalized tinynav js file in the module, and it works fine now. Thank you.
It'd be great if you could put a temporary note on the project page that says something like: "Note: Please use version 1.2 with its included fallback js file instead of installing tinynav from GitHub as there is a known bug that we are working to resolve
." or something. I do see that you've made mention of adapted code and a patch up for review, but t wasn't clear to me that I didn't have to install tinynav and that it was better for quick off-the-shelf use if I didn't use the Github library. The one tutorial I saw, which was using it with Omega, instructed to install the library from Github, so I can see others getting confused.
Thanks again!
Comment #7
btopro CreditAttribution: btopro commentedhmm... good point, sorry been awhile since I've attended to this project so that's a good idea.
Adding to the front page
Comment #8
btopro CreditAttribution: btopro commentedFallback method works
Comment #9
hass CreditAttribution: hass commentedWhat is the fixing commit?
Comment #10
btopro CreditAttribution: btopro commentedWe don't support the external library anymore. Documentation.
Comment #11
hass CreditAttribution: hass commentedBut the fork was always completly out of date or has it updated? Why are you reinventing the wheel?
Comment #12
btopro CreditAttribution: btopro commentedas per project front page:
#1942604: Drop support for original Library / libraries implementation
https://www.drupal.org/node/1942604#comment-8015807 -- we have to patch the library already to make it work w/ drupal. The maintainer has authorized us to include a fork. This is a ridiculously small library with targetted purpose and with all the other projects out there doing similar things this has ease of implementation / installation / use as a selling point (if any).
We can sync back up with the Tinynav library if need be but at the time, this also supported multiple levels of nesting where tinynav didn't and ran ahead of the supported tinynav release thanks to patches from this queue and theres.
If you are willing to patch this to utilize a 3rd party library effectively again then please do, there is still support in the current repo for the library based version but it is a fallback and based on all issue reports, non-functioning OOTB.