I haven't checked yet (except that the info file has no update function) but in case someone else already knows:

What is the upgrade path between 7.x-2.x and 7.x-4.x like?

Can a user just upgrade from one to the other without functionality changing?

Any changes/additions to settings and permissions will have to be done in an update function to make it work as close as possible to 7.x-2.x with an upgrade.

Also, possibly display messages to the user if they need to manually check anything, like settings and permissions.

In theory if this upgrade path is ok then all the 7.x-2.x issues in the issue queue can be closed with a note to say that that version is no longer supported (once the new version of 4.x comes out).

CommentFileSizeAuthor
#4 autologout-upgrade_path_2x_4x-1993310-7415356.patch1.42 KBjohnennew
#3 autologout-upgrade_path_2x_4x-1993310-7415140.patch1.46 KBjohnennew
#2 autologout-upgrade_path_2x_4x-1993310-7407084.patch1.2 KBjohnennew

Comments

johnennew’s picture

johnennew commented

Yes, this would be nice. I haven't tested this either so needs some work.

johnennew’s picture

johnennew commented
Version: 7.x-4.x-dev » 6.x-4.x-dev
Status: Active » Needs review
StatusFileSize
new autologout-upgrade_path_2x_4x-1993310-7407084.patch1.2 KB

I did the 6.x branch first - patch attached.

Not a perfect update, recommend users review the settings screen after update.

johnennew’s picture

johnennew commented
StatusFileSize
new autologout-upgrade_path_2x_4x-1993310-7415140.patch1.46 KB

Left over table autologout caused by the disable by user functionality in the 2.x branch which is not in the 4.x branch.

I'm deleting the table here and so not carrying over these settings. Good idea?

johnennew’s picture

johnennew commented
Version: 6.x-4.x-dev » 7.x-4.x-dev
StatusFileSize
new autologout-upgrade_path_2x_4x-1993310-7415356.patch1.42 KB

and the 7.x-4.x upgrade function.

johnennew’s picture

johnennew commented

I believe these upgrade paths are better than nothing so committing to 7.x-4.x and 6.x-4.x branches.

Would be good to get some more reviews from someone who can test this on a development version of a real site.

I think the only missing element is the removal of per user disabling of autologout available in 2.x but not 4.x. It is possible to disable autologout by role with the 4.x branches which I think is a superior solution than individually disabling users but does require some configuration after update by the site administrator.

rooby’s picture

rooby commented

I will try make some time to give it a test run but it won't be with a proper site.

I agree that per user config is not so useful, at least for use cases I can think of.

stefank’s picture

stefank commented

Hi

After upgrating from 7.x-2.x to 7.x-4.x I've got an error on site, without the window to confirm to continue or logout to appear. That happens when the function tries to autologout.

An AJAX HTTP error occurred.
HTTP Result Code: 404
Debugging information follows.
Path: /autologout_ajax_get_time_left
StatusText: Not Found
ResponseText:
Oops! This page doesn't exist.

The module is trying to go to path http://site/autologout_ajax_get_time_left.
What i can see it's in line 182 url: Drupal.settings.basePath + 'autologout_ajax_get_time_left',
for some reason the path is ignored an only the 'autologout_ajax_get_time_left' appears as path.

Thanks

johnennew’s picture

johnennew commented

Hi Stefank, The path is correct as far as I can see. A 404 would suggest Drupal cannot route the request which suggests that it doesn't recognise the path - can you clear cache just to be sure it's not something as simple as that.

stefank’s picture

stefank commented

Perfect. Silly mistake.

Thanks

Mig’s picture

Mig commented

Hi,

I have installed the 7.x-4.x module, and I am experiencing the same problem as stefank posted two days ago but i can't solve it cleaning the cache.

Hubo un error HTTP AJAX.
Código de Resultado HTTP:404
A continuación se detalla la información de depuración
Ruta: /prueba/autologout_ajax_get_time_left
StatusText: Not Found
ResponseText:
404 Not Found
NotFound
The requested URL /prueba/autologout_ajax_get_time_left was not found on this server.

any suggestions?

Thanks.

rooby’s picture

rooby commented

@Mig,

This is an issue for the upgrade path between the 7.x-2.x version and the 7.x-4.x version.
Did you upgrade from a 7.x-2.x version?

If not it would be best to open a new issue for your problem.

jmcollantes’s picture

jmcollantes commented

I have recently jumped from 7.x-2.0-beta1 to 7.x-4.2, everything sweet!

Substitued the autologout folder and ran update.php

Happily working on ***4.2 since then!

johnennew’s picture

johnennew commented

Thanks for the review @jmcollantes! Much appreciated.

johnennew’s picture

johnennew commented
Issue summary: View changes
Status: Needs review » Closed (fixed)

closing this old issue - looks like the update path works - feel free to reopen if you find soemthing.

  • Commit 247d4e7 on 7.x-4.x, 8.x-1.x by ceng: 
    Issue #1993310 by ceng: Added upgrade function for moving between 2.x...