Problem/Motivation

A bug is stopping the administrator being able to decline points in the moderation queue.
I found the problem both in 1.0 and 1.x-dev.

Proposed resolution

Row 307 in useradmin.module needs to be changed from:
$items['user/%user/points/%userpoints_transaction/decline'] = array(

to:
$items[$local_task_prefix . '/%userpoints_transaction/decline'] = array(

CommentFileSizeAuthor
#5 userpoints-1993354-fix_decline_link-5.patch551 bytesPatchRanger
#2 userpoints-module-1993354-.patch521 bytescosmoresearcher
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Sounds correct, please provide a patch :)

cosmoresearcher’s picture

cosmoresearcher CreditAttribution: cosmoresearcher commented
FileSize
userpoints-module-1993354-.patch521 bytes

Here you go, credits to druncore

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Active » Needs review

I guess it should be committed ASAP.

Status: Needs review » Needs work

The last submitted patch, userpoints-module-1993354-.patch, failed testing.

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Needs review
FileSize
userpoints-1993354-fix_decline_link-5.patch551 bytes

Here is the patch for 7.x-2.x first. Credits to @druncore.

Status: Needs review » Needs work

The last submitted patch, userpoints-1993354-fix_decline_link-5.patch, failed testing.

PatchRanger’s picture

PatchRanger CreditAttribution: PatchRanger commented

Here is the follow-up issue for failing testing: #2122333: Enable branch testing as 7.x-2.x seems to be broken.