In previous patches, the title field displayed the soft length limit message. In the current release it no longer displays. The fields for capturing the limits exists, but the message does not display.

CommentFileSizeAuthor
#14 soft-length-limit_fix-titles_1995658-10.patch1.82 KBrichburke
#9 soft_length_limit-fix_titles-1995658-09.patch4.76 KBtoddtomlinson
#8 screenshot_20130528-16:04:43.png70.95 KBelijah lynn
#6 soft_length_limit-fix_titles-1995658-06.patch5.26 KBtoddtomlinson
#5 soft_length_limit-fix_titles-1995658-05.patch5.27 KBtoddtomlinson
#3 soft_length_limit-fix_so_titles_work_again-1995658-03.patch5.13 KBtoddtomlinson
#2 soft_length_limit-fix_so_titles_work_again-1995658-01.patch4.15 KBtoddtomlinson
Screen Shot 2013-05-15 at 10.12.16 AM.png66.17 KBtoddtomlinson
Screen Shot 2013-05-15 at 10.11.57 AM.png96.37 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented

Creating a patch to fix this issue. Patch up soon.

toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new soft_length_limit-fix_so_titles_work_again-1995658-01.patch4.15 KB

Patch attached that fixes the issue of soft length limit not working for titles.

1) Added the field to collect whether the editor wants the enhanced or original version of soft length limit
2) Updated the css to add the container for title (vs fields)

toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new soft_length_limit-fix_so_titles_work_again-1995658-03.patch5.13 KB

The attached fixes the issue of the title not showing the soft length limit when just the title has a limit and no other fields do. This includes everything in the previous patch, plus this one use case.

toddtomlinson’s picture

toddtomlinson commented
Status: Active » Needs review
toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new soft_length_limit-fix_titles-1995658-05.patch5.27 KB

Revised all inclusive patch with minor fix.

toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new soft_length_limit-fix_titles-1995658-06.patch5.26 KB

Revised patch - fixing the issue where the variable for the style is set.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented 
+++ b/soft_length_limit.infoundefined
@@ -2,3 +2,10 @@ name = Soft length limit
+
+; Information added by drupal.org packaging script on 2013-05-01
+version = "7.x-1.x-dev"
+core = "7.x"
+project = "soft_length_limit"
+datestamp = "1367371969"

This should not be in the patch, it gets added by the packaging script.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Needs review » Needs work
StatusFileSize
new screenshot_20130528-16:04:43.png70.95 KB

Other than the issue in #7 where it doesn't apply cleanly this does appear to allow soft length limit work on titles. However, it creates this set of errors when saving the content type (bundle) settings.

Notice: Use of undefined constant SOFT_LENGTH_SELECT_STYLE - assumed 'SOFT_LENGTH_SELECT_STYLE' in soft_length_limit_set_title_maxlength() (line 118 of /home/elijah/websites/loc.example.com/docroot/profiles/all/modules/contrib/soft_length_limit/soft_length_limit.module).
Notice: Use of undefined constant SOFT_LENGTH_SELECT_STYLE - assumed 'SOFT_LENGTH_SELECT_STYLE' in soft_length_limit_set_title_maxlength() (line 118 of /home/elijah/websites/loc.example.com/docroot/profiles/all/modules/contrib/soft_length_limit/soft_length_limit.module).
Notice: Undefined index: SOFT_LENGTH_SELECT_STYLE in soft_length_limit_set_title_maxlength() (line 118 of /home/elijah/websites/loc.example.com/docroot/profiles/all/modules/contrib/soft_length_limit/soft_length_limit.module).
toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new soft_length_limit-fix_titles-1995658-09.patch4.76 KB

Fixed issues identified by Elijah in comments above. New patch attached.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Needs work » Reviewed & tested by the community

Works, thanks Todd!

SYarlagadda’s picture

SYarlagadda commented
Status: Reviewed & tested by the community » Needs work

This does not seem to work for certain content types. It does not show icons for some of them.

I cannot reproduce this always. But I will post back if I will ever be able to reproduce.

esbenvb’s picture

esbenvb commented
Status: Needs work » Closed (fixed)

Patch has been applied, among some other changes and a new dev release has been made.

There was also a problem with node titles that had no minimum length specified, i made 0 the default value now, and fixed the missing javascript when the title was the only soft length limited element. And fixed some code standard issues - always remember to run pareview.sh before posting a patch and look at your patch files for unintended extra spaces, removed spaces etc.

toddtomlinson or Elijah Lynn would you be interested in co-maintaining the module? At the moment i have not got that much time for the module and the system where we use it, only requires the basic functionality I made initially.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented

Hi Esben,

I would be interested in co-maintaining the module with you. We are currently using it for a lot of sites and it would definitely help us out.

Thanks

richburke’s picture

richburke commented
Status: Closed (fixed) » Active
Issue tags: +Fix for the issue reported by SYarlagadda, +wherein SLL doesn't work for custom Content Types
StatusFileSize
new soft-length-limit_fix-titles_1995658-10.patch1.82 KB

Fix for the situation in which SLLs don't appear for custom Content Type titles.

This patch is dependent upon a patch that will be submitted by my colleague. Until that time, I've marked the status as Active.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Active » Fixed

Thanks Rich,

Lets open a new issue for this though since this one has already been applied/fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.