Fatal when using a role contextual filter

Would be cool IMO to paste the view yaml into the bug report so we can skip creating the view. Hope we get there one day.

The patch makes it return a boolean, though. I think the code should be something like

if ($entity = entity_load(...)) {
  return $entity->label();
}

#5: drupal-1995868-05-Role-Contextual-Filter-WSOD.patch queued for re-testing.

Looks good to me, but I don't know Views enough to RTBC myself.

On a standard download of Drupal 8, the steps outlined in the issue summary by xjm produced a white screen of death for me. See screenshot.

After applying patch drupal-1995868-05-Role-Contextual-Filter-WSOD.patch from #5 by JoshuaRogers to a fresh Drupal 8 install, the path correctly gave me the view in Drupal instead of the WSOD. See screenshot with no perceived detriment in functionality. Good job!

We need a test for this...

Let's phpunit that!

Just a couple of comments about the test as I was chatting with dawehner in irc about it...

+++ b/core/modules/user/tests/Drupal/Tests/user/Views/Argument/RolesRidTest.phpundefined
@@ -0,0 +1,99 @@
+    // NULL forces to disable mocking on any method by default.

I'd prefer a comment here about what we're actually doing, rather than about how PHPUnit behaves, e.g. "Create a stub role storage controller that replaces the attachLoad method."

+++ b/core/modules/user/tests/Drupal/Tests/user/Views/Argument/RolesRidTest.phpundefined
@@ -0,0 +1,99 @@
+
+    $container = new ContainerBuilder();
+    $container->set('plugin.manager.entity', $entity_manager);
+    \Drupal::setContainer($container);

Why is this needed? I thought our PHPUnit tests could be a container-free zone. Wah.

Why is this needed? I thought our PHPUnit tests could be a container-free zone. Wah.

Sadly not at the moment but I think there is no reason to not inject it all the time?

+++ b/core/lib/Drupal/Core/Entity/Entity.phpundefined
@@ -363,7 +363,7 @@ public function createDuplicate() {
-    return entity_get_info($this->entityType);
+    return \Drupal::entityManager()->getDefinition($this->entityType());

Nice!

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument/RolesRid.phpundefined
@@ -19,8 +22,46 @@
+   * The role entity storage controller
+   */
+  protected $roleStorageController;

Missing @var

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/argument/RolesRid.phpundefined
@@ -19,8 +22,46 @@
+   * @{inheritdoc}

{@inheritdoc

+++ b/core/tests/Drupal/Tests/UnitTestCase.phpundefined
@@ -7,6 +7,9 @@
+use Drupal\Core\Config\Config;
+use Drupal\Core\Config\ConfigFactory;

Where are these used?

Where are these used?

Ups.

Thanks, looks great!

Committed 5bf482f and pushed to 8.x. Thanks!

followup #2017449: Drupal\Tests\user\Views\Argument\RolesRidTest is in the wrong place