Don't change the password reminder form too much [#1996664]

/**
 * Implements hook_form_FORM_ID_alter().
 */
function email_registration_form_user_pass_alter(&$form, &$form_state) {
  $form['name']['#title'] = t('E-mail');
  $form['name']['#description'] = t('A password reset message will be sent to your e-mail address.');
}

These seem like pointless changes to me, and out of scope of the module:

- 'Username or e-mail address' -> 'E-mail'

Given we are not changing this form in any functional way, I assume a username will continue to work, despite our no longer announcing it.

> $form['name']['#description'] = t('A password reset message will be sent to your e-mail address.');

This is an addition -- core has nothing here. The button text is presumably descriptive enough. If not, it's a bug to file on core. It seems to me to be out of this module's scope to fix this sort of thing.

Comment	File	Size	Author
#5	1996664_remove_description_8x.patch	495 bytes	greggles
#3	1996664_remove_description.patch	495 bytes	greggles

Comments

Comment #1

greggles

he/him

English

Denver, Colorado, USA

commented 16 May 2013 at 19:36

Title:

don't change the password reminder form

» Don't change the password reminder form too much

My sense from the issue queue is that for many users of the module it is confusing UX to show "username" inside the site. So, I'm inclined to keep the alter of the ['name']['#title']. If a specific site wants to change the message that would be fine for them to do in their own code/config.

I would be fine dropping the description.

Comment #2

joachim commented 22 May 2013 at 14:15

Status:

Active

» Postponed

> - 'Username or e-mail address' -> 'E-mail'

This change makes sense for now (well, technically, it's lying by omission, as the logic behind the form will still allow use of the username!).

Once #657472: Add setting to allow users to login with email address or username gets in though, it should change conditionally on the setting introduced by that patch.

Comment #3

greggles

he/him

English

Denver, Colorado, USA

commented 3 September 2013 at 15:20

Status:

Postponed

» Needs review

Status	File	Size
new	1996664_remove_description.patch	495 bytes

How about this?

Comment #4

joachim commented 3 September 2013 at 15:28

Status:

Needs review

» Reviewed & tested by the community

Looks good to me!

+++ b/email_registration.module
@@ -121,7 +121,6 @@ function email_registration_form_user_register_form_alter(&$form, &$form_state)
   $form['name']['#title'] = t('E-mail');

Changing this to 'Username or e-mail address' will then be part of #657472: Add setting to allow users to login with email address or username.