[D7] Advanced Text Formatter

I did a cursory read through the code, and on first glance I don't see any major issues. This is a good idea for a module, a colleague and I built something similar for a custom site in D6, it's good to see someone make something reusable for D7.

A few things about functionality (maybe the documentation could clear this up?):

1) Token replace. It's not clear to me what this should be doing. I'd assume that it allows for text patterns to be replaced by token values, but I don't see anything after I check the box.

2) Display / Filtering. This part is a little confusing to me as well, as it deviates a bit from how I've seen it handled elsewhere. Isn't the Display setting redundant since filtering should control whether it's outputted as plain text/HTML?

Also, I don't understand the purpose of PHP Strip Tags - shouldn't the text filter itself control what is and isn't stripped? Perhaps your goal is to give a bit more control on the fly? Either way, it would be good to give it a more user-friendly name.

Thanks for the code and good luck with the application process! Looks like this will be a great contrib module.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello thmnhat, one last thing from me then - if you do include a token replace, maybe you could display a collapsible table of available tokens (like other modules do) so users know what tokens are available?

Few minor suggestions:

advanced_text_formatter.module

- Line 12: text.info (which requires field.module) has required = TRUE which means the module will always be enabled. It won't be necessary to check module_exists('text')

- Line 159: t('Replace text pattern. e.g [node:title] or [node:author:name], by token values.'). This text is not very translation-friendly.
You could rewrite to use some patterns so tokens are excluded from the translation string.
EX:
t('Replace text pattern. e.g %node-title-token or %node-author-token, by token values.', array('%node-title-token' => '[node:title]', '%node-author-token' => '[node:author:name]'))

- Line 198: Use @link instead of !link.

Good job, and this module looks like a really useful and handy one.

Good job!

manual review:
advanced_text_formatter_field_formatter_view(): strip_tags() is not considered secure (for old browsers and PHP versions), you need to use filter_xss() instead. This is a security blocker. See also http://drupal.org/node/28984 . And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

But otherwise looks nearly ready to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Add Review links

Hi Nhat,

Thanks again very much for contributing this very nice module and I'm sorry for this late review/reply/comment.

You've really done a great work on this project application:
Very complete module page, clean code, nice inline comments, coding standards, etc... and promptly following up with all comments/suggestions posted by other reviewers in this ticket, while kindly participating to the Review Bonus program.

At this point, It seems there is not much left anymore for me to comment on or complain about your application, and I certainly didn't expect you would get RTBC as quickly as that :) (and get so many helpful reviews).
I guess the preparation you did before submitting the application (by getting at least all the automated checklist out of the way) really helped speeding up the reviewing process.

Just a very minor suggestion, you might want to wait for another user to set the application again RTBC and I would assume it might have been a bit better if you had changed the status to needs review in #12, instead of RTBC yourself.

Usually, after the application has been marked RTBC, you should be about a week close to getting it fixed and seeing the module promoted to full project (if no other objections or issues are reported during that time).

Thank you very much for your efforts going through this process and we will certainly keep watching this very nice module with a lot of interest.
Cheers!

Thanks for your contribution, thmnhat!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.