Allow the boolean labels of exposed filters to be configurable

This is a start to allow to configure any kind of label using the grouped filter functionality.

Let's add proper test + fix some notices.

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/FilterBooleanWebTest.phpundefined
@@ -0,0 +1,90 @@
+    debug($display['display_options']['filters']['age']);

I think this is by mistake or missing assertion.

Fixed that.

Fixed that.

Here is a test for the actual logic of the filter value. Things are slightly broken atm.

Fixed up based on your feedback, thanks Daniel.

Sorry, missed the interdiff.

EDIT: This is the wrong patch. #7 is good. posted on the wrong issue.

#7: 1998192-7.patch queued for re-testing.

#8: 1998192-8.patch queued for re-testing.

We just need to retest #7.

#13: 1998192-7.patch queued for re-testing.

I *think* this should fix the tests now. Let's see..

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/BooleanOperator.phpundefined
@@ -165,10 +197,23 @@ public function defaultExposeOptions() {
+  /**
+   * @param string $field
+   */
+  protected function queryOpBoolean($field) {

Sorry .. needs docs.

+++ b/core/modules/views/lib/Drupal/views/Tests/Handler/FilterBooleanOperatorTest.phpundefined
@@ -0,0 +1,97 @@
+ * Tests the core Drupal\views\Plugin\views\filter\InOperator handler.

Could get one @see as well.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewTestData.phpundefined
@@ -112,6 +112,13 @@ public static function schemaDefinition() {
+        'status' => array(
+          'description' => "The status of this record",
+          'type' => 'int',
+          'unsigned' => TRUE,
+          'not null' => TRUE,
+          'default' => 0,
+        ),

@@ -219,6 +226,19 @@ public static function viewsData() {
+    $data['views_test_data']['status'] = array(
+      'title' => t('Status'),
+      'help' => t('The status of this record'),
+      'field' => array(
+        'id' => 'boolean',
+      ),
+      'filter' => array(
+        'id' => 'boolean',
+      ),
+      'sort' => array(
+        'id' => 'standard',
+      ),

@@ -232,30 +252,35 @@ public static function dataSet() {
+        'status' => 1,
...
+        'status' => 0,
...
+        'status' => 1,
...
+        'status' => 0,
...
+        'status' => 1,

So for the UI test we alter and for the unit test we add this feel all the time? This seems unconsistent. I would personally vote to alter both times.

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/FilterBooleanWebTest.phpundefined
@@ -0,0 +1,84 @@
+ * @see \Drupal\views\Plugin\views\filter\BooleanOperator

yeah!!

I'm not sure about altering the views test data to add this handler, as for things like ID we always have that field around, status we don't so altering wouldn't help? not unless we already had a handler on the view, but it would use Boolean anyways.

Sorry, with the right patch and not two interdiffs.

I still think that if we add boolean fields to all beatles we should leverage it in both tests.

:(

Sorry, I see exactly what you mean now. We should use the status handler in the UI test instead of altering the data on the age field :)

I'm glad you understood me. Perfect! (Once the testbot liked us).

Needs a reroll...

curl https://drupal.org/files/1998192-25.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12742  100 12742    0     0   9052      0  0:00:01  0:00:01 --:--:-- 10600
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/BooleanOperator.php:96
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/BooleanOperator.php: patch does not apply

rerolled

Back to RTBC, yeah!

Committed 0e8571d and pushed to 8.x. Thanks!

This wasn't perfect yet :( #2024893-4: Change status filter on admin/people to 'active'/'blocked'