Remove hook_menu_site_status_alter() in favor of request listeners

But that should get ripped out and put into the MaintenanceModeSubscriber

or an equivalent of user's module subscriber since it contains user module specific logic

Trying to work on that.

After some research it comes clear that there is more then one place:

• Menu_test: This one is just testing the alter hook
• User: logout users, if they aren't admin and redirect properly
• openid: Allows openid endpoints to work on offline sites
• openid_test: Sets the site offline to ensure openid is still working offline

It feels like the approach we could do is to add some key to the response object, which is then checked by MaintenanceModeSubscriber to determine
whether it still wants to be offline and then return the rendered maintenance page. To set a site offline you would implement KernelEvents::REQUEST
with a lower weight then MaintenanceModeSubscriber ... Does this make sense?

yes, adding a key would save calls to _menu_site_is_offline.
A lot better, than subribers having to reimplement the same logic as MaintenanceModeSubscriber

Started with a patch, but for some odd reasons the event subscribers doesn't run in the proper order

That said, I don't think we need to bother splitting these two listeners to separate methods.

We need to let other modules decide whether they want the site to be in offline status before invoking drupal_maintenance_theme and friends..i think the performance hit is not that big that not calling drupal_alter doesnt make up for it?

This is a interdiff between #5 and #7

#9: drupal-1998228-9.patch queued for re-testing.

fixed the @todo now that #1987894: Convert user_logout() to a new style controller is in

Maybe i'm pessimistic, but isn't something like user_logout() an actual helpful api function?

you are right..but i cant find a correct place for this, esp. when session is not a service
maybe a manager-like hack?

lets do this for now:
since it is considered an API function, moved in user.module
updated the UserController to call that instead of duplicating logic
removed the redirection..so it only kill session, calls watchdog and triggers the hook

also..no openid here, thats why the patch is smaller

sigh

+++ b/core/modules/user/user.moduleundefined
@@ -2785,3 +2743,17 @@ function user_library_info() {
+/**
+ * Logs the current user out.
+ */
+function user_logout() {
+  global $user;
+
+  watchdog('user', 'Session closed for %name.', array('%name' => $user->name));
+
+  Drupal::moduleHandler()->invokeAll('user_logout', array($user));
+
+  // Destroy the current session, and reset $user to the anonymous user.
+  session_destroy();
+}

Can't we have some kind of class for that which deals with this?

is it really under the scope of this issue?

I agree.

I think @dawehner meant RTBC :)

for one moment i thought dawehner got commit access:P
opened #2012976: Deprecate user_logout() and user_login_finalize() and replace with a service for discussing what to do with user_logout

So you're killing the hook... that means we need to remove it from system.api.php and it is also referenced in MenuRouterTest::testMaintenanceModeLoginPaths - we should be pointing people at the new event here.

oh, i am sorry, you are totally right, i missed those

Great!

Needs a reroll

curl https://drupal.org/files/drupal-1998228-27.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17544  100 17544    0     0  11728      0  0:00:01  0:00:01 --:--:-- 18294
error: patch failed: core/modules/user/lib/Drupal/user/Controller/UserController.php:11
error: core/modules/user/lib/Drupal/user/Controller/UserController.php: patch does not apply

reroll

#30: drupal-1998228-30.patch queued for re-testing.

finally

Committed 27bd89b and pushed to 8.x. Thanks!

Change notice https://drupal.org/node/2020005

Change notice https://drupal.org/node/2020005

Untagging. Please remove the tag when the change notification task is completed.

d.o--