What is the purpose of passwordInput.focus(); ?

I'm running a site with a theme running jQuery 1.9 and passwordInput.focus(); seems to pull focus back to the password input field all the time, regardless of whether the password meets policy compliance or not and means you can't do anything else on the page. This behaviour does not happen in any Drupal supported version of jQuery as far as I can see.

I commented out the line (28) and nothing seemed to break and password_policy then works with jQuery 1.9. Is this focus line needed?

CommentFileSizeAuthor
#2 password_policy-remove_focus-1998862-7455062.patch462 bytesjohnennew

Comments

erikwebb’s picture

erikwebb commented

I personally don't think it needs to be there. It's probably leftover from an old implementation. Care to supply a patch to review?

johnennew’s picture

johnennew commented
Status: Active » Needs review
StatusFileSize
new password_policy-remove_focus-1998862-7455062.patch462 bytes

sure, patch attached.

erikwebb’s picture

erikwebb commented
Title: focus call in JS with jQuery 1.9 » Remove JS focus call
Category: support » feature
Status: Needs review » Fixed

Committed and attributed. Thanks!

http://drupalcode.org/project/password_policy.git/commit/3302bb4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.