Convert core/modules/search/lib/Drupal/search/Tests/SearchExpressionTest.php to phpunit

It would be great to convert this to dataProviders

$cases = array(
array('foo', 'bar', 'foo:bar', 'bar'), // Normal case.
array('foo', NULL, '', NULL), // Empty value: shouldn't insert.
array('foo', ' ', 'foo:', ''), // Space as value: should insert but retrieve empty string.
array('foo', '', 'foo:', ''), // Empty string as value: should insert but retrieve empty string.
array('foo', '0', 'foo:0', '0'), // String zero as value: should insert.
array('foo', 0, 'foo:0', '0'), // Numeric zero as value: should insert.
);

PS: It might make sense to put this static stuff into classes.

.

yeah we should first convert procedural code to OOP and its test to PHPUnit first:) not the other way around

Instead of relying on pure static methods I think we have clearly an object here: the search expression.

besides the assertion message everything looks good. if we want to keep them we should reverse them, so they make some sense when phpunit displays them (only upon failure)

The message should be also inverted, as it is just displayed on failure.

#7: search_expression-2002190-7.patch queued for re-testing.

Oh thanks! I fear that I can't RTBC it.

i love this patch, thanks!

this is the case for simpletest not PHPUnit. PHPUnit only displays those messages upon failure.
assertEquals example:

Reports an error identified by $message if the two variables $expected and $actual are not equal.

Committed 7b0039e and pushed to 8.x. Thanks!