Files: 
CommentFileSizeAuthor
#22 2002972-22.patch6.6 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 55,504 pass(es).
[ View ]
#19 2002972-19-rename-views-method.patch6.56 KBlokapujya
PASSED: [[SimpleTest]]: [MySQL] 55,983 pass(es).
[ View ]
#13 2002972-13-rename-views-method.patch7.44 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 57,874 pass(es).
[ View ]
#12 2002972-rename-views-method_12.patch6.55 KBtvlooy
PASSED: [[SimpleTest]]: [MySQL] 55,900 pass(es).
[ View ]
#6 2002972-rename-views-method.patch6.54 KBlokapujya
PASSED: [[SimpleTest]]: [MySQL] 55,983 pass(es).
[ View ]
#2 2002972-rename-views-method.patch0 byteslokapujya
PASSED: [[SimpleTest]]: [MySQL] 55,927 pass(es).
[ View ]

Comments

Assigned:Unassigned» lokapujya

StatusFileSize
new0 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,927 pass(es).
[ View ]

Drupal Portland Code Sprint!

Status:Active» Needs review

Status:Needs review» Needs work

Patch is 0 bytes.

Reroll patch -- 0kb for some reason

StatusFileSize
new6.54 KB
PASSED: [[SimpleTest]]: [MySQL] 55,983 pass(es).
[ View ]

Thanks for reviewing. Patch fixed.

Status:Needs work» Needs review

Status:Needs review» Reviewed & tested by the community

applied patch, tested views, worked well! After robot thing goes through ready to go in!

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002972-rename-views-method.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#6: 2002972-rename-views-method.patch queued for re-testing.

Status:Needs review» Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

Status:Needs work» Needs review
StatusFileSize
new6.55 KB
PASSED: [[SimpleTest]]: [MySQL] 55,900 pass(es).
[ View ]

Added the access modifiers.

StatusFileSize
new7.44 KB
PASSED: [[SimpleTest]]: [MySQL] 57,874 pass(es).
[ View ]

@tvlooy thanks for working on this.

I went ahead and re-rolled the patch since there were other instances of tokenize_value() being used. I believe you only checked the views module? When we rename the functions we need to grep across the whole drupal_root directory. Sometimes other modules run tests that reference functions that do not belong to the module calling the function.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002972-13-rename-views-method.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#13: 2002972-13-rename-views-method.patch queued for re-testing.

The patch in #13 changes 2 instances of render_trim_text to RenderTrimText which is actually handled by a separate issue. The patch in #12 is the correct patch.

@lokapujya I apologize about that, I must have not reset the git repo before making the patch.

The reason I rolled #13 was because #12 was missing a few renames of tokenize_value(). So #12 and #13 need to be rerolled. If this is not rerolled by this evening I will work on it.

Thanks for catching the problem.

Status:Needs review» Needs work

Unfortunately we need a reroll to the newest Drupal core as well, the patch doesn't apply anymore.

Status:Needs work» Needs review
StatusFileSize
new6.56 KB
PASSED: [[SimpleTest]]: [MySQL] 55,983 pass(es).
[ View ]

Re-rolled. I found 11 instances of tokenize_value(). They were all within the Views module.

Status:Needs review» Reviewed & tested by the community

@lokapujya thanks for re-rolling. Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

Status:Reviewed & tested by the community» Needs work

Needs a reroll

curl http://drupal.org/files/2002972-19-rename-views-method.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6717  100  6717    0     0  12790      0 --:--:-- --:--:-- --:--:-- 19246
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/area/Text.php:67
error: core/modules/views/lib/Drupal/views/Plugin/views/area/Text.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/area/TextCustom.php:61
error: core/modules/views/lib/Drupal/views/Plugin/views/area/TextCustom.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:340
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply

Status:Needs work» Needs review
StatusFileSize
new6.6 KB
PASSED: [[SimpleTest]]: [MySQL] 55,504 pass(es).
[ View ]

Reroll

Status:Needs review» Reviewed & tested by the community

GTG.

Status:Reviewed & tested by the community» Fixed

Committed 8612773 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.