It would be nice if we could configure other options on the formatter such as the scrollWheelZoom. I will work on a patch.

CommentFileSizeAuthor
#19 leaflet-scrollWheelZoom-2002976-19.patch3.88 KByannickoo
#17 leaflet-scrollWheelZoom-2002976-17.patch3.88 KByannickoo
#12 leaflet-scrollWheelZoom-2002976-12.patch3.27 KByannickoo
#10 disable-scrollWheelZoom-2002976-10.patch2 KBbneil
#10 interdiff-2002976-9-10.txt494 bytesbneil
#9 disable-scrollWheelZoom-2002976-9.patch1.98 KBbriand44
#5 leaflet-ability-to-disable-2002976-5.patch3.38 KBbriand44
#3 leaflet-ability-to-disable-2002976-2.patch2.11 KBrichardbporter
#2 leaflet-ability-to-disable-2002976-2.patch2.13 KBrichardbporter
#1 leaflet-scrollWheelZoom-2002976-1.patch1.66 KBbriand44
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

briand44’s picture

briand44 CreditAttribution: briand44 commented
Status: Active » Needs review
FileSize
leaflet-scrollWheelZoom-2002976-1.patch1.66 KB

Here is the patch. It just adds a checkbox to disable the scrollWheelZoom.

richardbporter’s picture

richardbporter CreditAttribution: richardbporter commented
FileSize
leaflet-ability-to-disable-2002976-2.patch2.13 KB

Tested and worked great but re-rolled to reverse the logic of the setting.

richardbporter’s picture

richardbporter CreditAttribution: richardbporter commented
FileSize
leaflet-ability-to-disable-2002976-2.patch2.11 KB

Removed a dpm() statement.

briand44’s picture

briand44 CreditAttribution: briand44 commented
Status: Needs review » Reviewed & tested by the community

Patch in #3 worked for me.

briand44’s picture

briand44 CreditAttribution: briand44 commented
Status: Reviewed & tested by the community » Needs review
FileSize
leaflet-ability-to-disable-2002976-5.patch3.38 KB

I created a new patch which adds the ability to disable the scrollWheelZoom in views as well.

danon1981’s picture

danon1981 CreditAttribution: danon1981 commented

Trying the patch in #5 failed

patching file leaflet_views/leaflet_views_plugin_style.inc
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 154.
Hunk #3 FAILED at 365.

Has someone else applied the patch in #5 successfully?

2pha’s picture

2pha
Primary language English
CreditAttribution: 2pha commented

the patch at: https://drupal.org/node/2089209 gives the ability to set all map options, including scrollWhelZoom.

gcb’s picture

gcb
he/him
CreditAttribution: gcb commented
Issue summary: View changes
Status: Needs review » Closed (duplicate)

Marking duplicate: if we are going to add this option we'll add the rest of the config options as in #2089209. Thanks for the patch though!

briand44’s picture

briand44 CreditAttribution: briand44 commented
Status: Closed (duplicate) » Needs review
FileSize
disable-scrollWheelZoom-2002976-9.patch1.98 KB

I am opening this issue back up because of https://drupal.org/comment/8182295#comment-8182295. I have re-created the patch to apply against the latest dev version.

bneil’s picture

bneil CreditAttribution: bneil commented
FileSize
interdiff-2002976-9-10.txt494 bytes
disable-scrollWheelZoom-2002976-10.patch2 KB

The functionality in #9 works as advertised. I did run into the issue identified in #2185767: Leaflet field formatter errors when trying to edit geocoded field in view or panel which is a separate issue and had to comment out #empty_options so I could test the patch.

I've modified only the #description to standardize it with the language used in the Leaflet API regarding the scroll wheel.

fullerja’s picture

fullerja CreditAttribution: fullerja commented
Status: Needs review » Reviewed & tested by the community

Patch in #10 works for me. I also had to comment out #empty_options to test leaflet_views

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo at Wunder commented
Status: Reviewed & tested by the community » Needs review
FileSize
leaflet-scrollWheelZoom-2002976-12.patch3.27 KB

Here is a new version of this patch, applies to latest dev :)

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Thanks yannickoo.
Rik

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Patch from #12 applied (but not tested yet).
Available now in Leaflet 7.x-1.x-dev and in the next official release, when ready.
Rik

  • RdeBoer committed 6f52dfb on 7.x-1.x authored by yannickoo 
    Issue #2002976 by briand44, rbp, bneil, yannickoo: Ability to disable...
RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented
Assigned: Unassigned » RdeBoer
Status: Needs review » Fixed

Consider this fixed until proven otherwise. Please someone test, as I don't have the time right now.
Rik

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo at Wunder commented
Status: Fixed » Needs review
FileSize
leaflet-scrollWheelZoom-2002976-17.patch3.88 KB

Sorry for re-opening but I found 2 issues in the current implementation:

  1. scroolWheelZoom should be enabled by default because this is the default Leaflet behavior for a map
  2. Default value for Views implementation was missing
  3. The if condition is wrong so when you don't want to have scroolWheelZoom it is not exposed to the JavaScript settings

I have uploaded a new patch :)

gifad’s picture

gifad CreditAttribution: gifad commented
Status: Needs review » Needs work

scroolWheelZoom

are you sure ?
don't you mean scrollWheelZoom ?

yannickoo’s picture

yannickoo
Location Berlin
CreditAttribution: yannickoo at Wunder commented
Status: Needs work » Needs review
FileSize
leaflet-scrollWheelZoom-2002976-19.patch3.88 KB

Sorry :D

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented

#19 works

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

@ac, @yannickoo
Re #19: Thanks -- will apply soon.
Rik

  • RdeBoer committed 5cd047a on 7.x-1.x authored by yannickoo 
    Issue #2002976 by briand44, yannickoo, rbp, bneil: Ability to disable...
RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented
Status: Needs review » Fixed

Considering this fixed now.
Reopen if not.
Available now in 7.x-1.x-dev or 7.x-1.2 when released.
Rik

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.