Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#3 | views-rename-op-equal.patch | 1.84 KB | zschmid |
#1 | views-rename-op-equal.patch | 1.84 KB | malcomio |
Comments
Comment #1
malcomio CreditAttribution: malcomio commentedComment #2
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the method to adher to the new OOP standards.
Comment #3
zschmid CreditAttribution: zschmid commentedPatch for adding public access modifier
Comment #4
zschmid CreditAttribution: zschmid commentedComment #5
zschmid CreditAttribution: zschmid commentedComment #7
oenie CreditAttribution: oenie commented#3: views-rename-op-equal.patch queued for re-testing.
Comment #9
oenie CreditAttribution: oenie commented#3: views-rename-op-equal.patch queued for re-testing.
Comment #10
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #11
dawehnerWe should decide first whether we have a proper naming for all this operation query methods and then get them in consistently.
Comment #12
alexpottCommitted b5411b1 and pushed to 8.x. Thanks!
Comment #13
heddnIf this is a public API call, then opFoo has zero meaning. Maybe addFoo is wrong but something has to be better than opFoo. Do we mean operation, opportunity, opening post? At least spell it out.
Comment #14
heddnI guess we can iron out the details about naming after massing conversion.