[D7] Scald OG

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Everything seems fine.
Only some small issue:
line 107 - $GLOBALS['user'] - it would be better to add global $user in top of function and after use this object.

I also reviewed the code and it's nice enough.
About the globals vs $GLOBALS argument, I think it's better not to pollute the whole function's variable scope with global variables, it's safer to always rely on the $GLOBALS.

What would be your argument against it?

Others seem to share this opinion as well: http://stackoverflow.com/questions/3573847/php-global-or-globals

PHP_Sniffer using coder_sniffer does not give me any errors which shows the compliance against Coding Standard, definitely good sign!

Reviewed and tested the module.
The code meets the drupal coding standards.
The module works as designed.

Nice module, good code.
Everything seems fine.

The project page is a bit light. I had to do additional research to try and guess what it's talking about.
Code is short, but the subject and APIs used are deep.
Visual review looks good. Well formed, appropriate APIs, well commented.
I'm unable to test this in action without a huge amount of bootstrapping, but I can see what it's doing.

With reference to other code contributions already attributed to nagy.balint and the technical depth shown here, this is good to go.
I'd promote you directly, but we generally do this as a two-step process. RTBC from me.

I'll look at this now in the Project applications sprint

Thanks for your contribution, nagy.balint!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.