Hi all.
Since there is no .test file in this module, i help create one.
See attachment.

Comments

dydave’s picture

Status: Needs review » Fixed

Hi @gaofengzzz,

Thanks a lot for posting this feature request and submitting a patch for the tests.
I apologize for this late reply, but it has taken me some time to go through the issue queue.

Looks like you've got the ball rolling for Test Cases and that's going to be tremendously useful for the future maintenance of the module.

I have tested and reviewed a little bit the patch and it seems like a basic start. At least all the tests are passed and modules functions seem to be tested up to a certain level.

So I went ahead and got the patch committed against the block_class-7.x-2.x branch at f4474ec.

I would still have many comments, suggestions and ideas for modifying the tests, that I think it would probably be better to post a new issue which would most likely be more specific.
I think there would be much more work to do on the Test Cases, so I have already posted another related and more specific issue at #2060319: Improve and document block_class.test.
After going through another round of changes for the tests, I suppose we could consider back-porting them to 7.x-1.x.

Therefore, I allowed myself to mark this issue as fixed for now (work on tests to be continued at #2060319: Improve and document block_class.test), but feel free to re-open this ticket, or post a new issue, at any time if you have any further objections with this the changes made at f4474ec (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on the commit or this ticket in general, I would be glad to provide more information or explain in more details.

Thanks in advance to everyone for your testing, reviews, feedback and comments on this issue.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.