Based on current logic, even if versioncontrol returned no branches, the groups are created, and since the array with the groups is checked, we end up never showing "empty repository" messages.

CommentFileSizeAuthor
#1 0001-Issue-2004190-by-marvil07-Prevents-showing-empty-bra.patch979 bytesmarvil07

Comments

marvil07’s picture

marvil07 commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-2004190-by-marvil07-Prevents-showing-empty-bra.patch979 bytes
helmo’s picture

helmo commented
Status: Needs review » Fixed

Committed, thanks.

Tested on: http://git-drupal_7.redesign.devdrupal.org/project/whois/git-instructions

marvil07’s picture

marvil07 commented

That was fast :-), thank you.

BTW maybe you want to use git am for the next time you need to apply a git patch with metadata like the one here ;-)

helmo’s picture

helmo commented

Yes, the commit attribution would have been better.

I got used to using patch as git apply often rejects patches, that don't match 100%, without feedback :(

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f32a93e on 7.x-1.x, 7.x-1.x-dev by helmo: 
    Issue #2004190 by marvil07: Fixed Prevent showing empty branch groups.