Closed (fixed)
Project:
Hostmaster (Aegir)
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 May 2013 at 14:22 UTC
Updated:
5 Jul 2013 at 23:30 UTC
The disable task (or worse yet, delete!) shouldn't be allowed (for Hostmaster site) via bulk site operations:

| Comment | File | Size | Author |
|---|---|---|---|
| disabled-hostmaster.jpg | 113.7 KB | omega8cc |
Comments
Comment #1
deciphered commentedGiven the approach taken in VBO 6.x, and the limitations of D6 in general, removing or disabling the checkbox would either require altering rendered HTML or using javascript, neither approach that I would particularly recommend.
The original suggestion I was given was simply to remove the Hostmaster site from the sites listing view altogether, and I'm inclined to go with this as in my personal experience I've never had a valid reason to access this site via Aegir itself, as it's just asking for trouble messing with it.
Removing the Hostmaster site from the view is also potentially tricky, as it can't be done by name, I'm not positive if it can be done by NID as there me be a valid reason why that could be different per install, doing it by Platform or Profile might not block at valid sites that happen to either be installed on the same platform or profile.... tricky.
Open to suggestions.
Comment #2
ergonlogicActually, we block sites from being created with the hostmaster profile, so that should be safe to filter against.
Comment #3
deciphered commentedProblem solved then:
Repo: http://drupalcode.org/sandbox/deciphered/2001932.git/shortlog/refs/heads...
Patch: http://drupalcode.org/sandbox/deciphered/2001932.git/patch/654910b70b6b2...
Comment #4
deciphered commentedAdditional commit adding empty text:
No sites created. <a href="/hosting/sites/add">Add a site</a>.Comment #5
ergonlogicThe hostmaster site can still be disabled/deleted from the view on the hostmaster platform page.
Comment #6
ergonlogicI fixed this in hosting_add_task(), where we essentially bail if a destructive task is being added to the hostmaster site. This should block all possible ways of disabling or deleting the hostmaster site, not just vbo.
Fixed in 9ce85f3.
Comment #7.0
(not verified) commentedPrecise that it is about Hostmaster site here.