The disable task (or worse yet, delete!) shouldn't be allowed (for Hostmaster site) via bulk site operations:

dis

CommentFileSizeAuthor
disabled-hostmaster.jpg113.7 KBomega8cc

Comments

deciphered’s picture

Given the approach taken in VBO 6.x, and the limitations of D6 in general, removing or disabling the checkbox would either require altering rendered HTML or using javascript, neither approach that I would particularly recommend.

The original suggestion I was given was simply to remove the Hostmaster site from the sites listing view altogether, and I'm inclined to go with this as in my personal experience I've never had a valid reason to access this site via Aegir itself, as it's just asking for trouble messing with it.

Removing the Hostmaster site from the view is also potentially tricky, as it can't be done by name, I'm not positive if it can be done by NID as there me be a valid reason why that could be different per install, doing it by Platform or Profile might not block at valid sites that happen to either be installed on the same platform or profile.... tricky.

Open to suggestions.

ergonlogic’s picture

Actually, we block sites from being created with the hostmaster profile, so that should be safe to filter against.

deciphered’s picture

deciphered’s picture

Additional commit adding empty text: No sites created. <a href="/hosting/sites/add">Add a site</a>.

ergonlogic’s picture

Status: Needs review » Needs work

The hostmaster site can still be disabled/deleted from the view on the hostmaster platform page.

ergonlogic’s picture

Status: Needs work » Fixed

I fixed this in hosting_add_task(), where we essentially bail if a destructive task is being added to the hostmaster site. This should block all possible ways of disabling or deleting the hostmaster site, not just vbo.

Fixed in 9ce85f3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Precise that it is about Hostmaster site here.