During install of a new site, changes in commit dc8726 seem to be causing the following error:
Invalid argument supplied for foreach() Service.php:144

Simple fix is to wrap the foreach loop with a is_array() conditional.

CommentFileSizeAuthor
#4 Service.php_.diff738 byteslieb

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review

http://drupalcode.org/sandbox/deciphered/2005700.git/shortlog/refs/heads...

Patch: http://drupalcode.org/sandbox/deciphered/2005700.git/patch/82a56dc32068e...

realityloop’s picture

realityloop commented
Status: Needs review » Reviewed & tested by the community

Deciphered's patch has fixed the issue for me

anarcat’s picture

anarcat commented
Status: Reviewed & tested by the community » Needs work

yum yum! i love RTBC patches! :) committed!

unfortunately, it's incomplete: i was a bad boy and made that error in a bunch of places in Service.php... maybe we want to initialize that array instead of doing foreach loops?

lieb’s picture

lieb commented
StatusFileSize
new Service.php_.diff738 bytes

This one initializes $_config as an array() . Tested with provison-install and provision-delete.

lieb’s picture

lieb commented
Status: Needs work » Needs review

I attached a patch in #4 but did not set the status to 'needs review' so I am doing so now.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

thanks, that looks better.

i had forgotten to push the other patch, which should have been reverted, so it won't need to be now. :) great! congrats on your first patch in, lieb!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 8f7139a on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by lieb, committed by anarcat: 
    Issue #2005698 by lieb: Fixed Invalid argument supplied for foreach()...