[D7] DaCast Streaming as a Service Integration

Check errors in http://ventral.org/pareview/httpgitdrupalorgsandboxdacast1991986git

There are too few comments.
Most functions does not have comments.

Format $forms array, at the moment the code is pretty unreadable.

Use t() function in messages.

Hi,

I did a manual review of your module and found the following errors.

• The link to your git repository need to be: git clone http://git.drupal.org/sandbox/DaCast/1991986.git dacast_streaming_as_a_service_integration
• You have a master branch in your project. This needs to be removed and your 7.x-1.x branch needs to be set as your default branch. Read Setting a default branch
• The dacast_view submodule has a dependency on dacast_video module which is not found. Is that another module or the main module itself? This needs to be corrected in your dacast_view.info file.
• Installing the module did not seem to install any content type or taxonomy for me. Is this working yet?
• You might want to move all admin related functions into an admin.inc file for better separation.
• Your implementation of hook_uninstall seems to be deleting all the content that was created. Are you sure this is what you want? If so, there should be a warning to the user before this happens. Also, the content type and taxonomy vocabulary are being deleted based on their machine name. If the machine name is changed by the user, this would fail.

You should also check ventral.org as suggested in the previous comment. There are quite a lot of errors. You probably would benefit reading the Drupal coding standards.

Good luck!

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review:

• Please update the issue summary in this thread to list the git link as git clone http://git.drupal.org/sandbox/DaCast/1991986.git dacast_video
• You need to change the default branch to 7.x-1.x and get rid of the master branch. See thamba's Link for help on how to do that.
• Remove the version definition from your .info file. Drupal will handle this automatically.
• You're missing a README.txt file at the module root.
• You have practically no comments in your files. All functions should have a comment block, along with comments within the code to help maintainers understand what's happening. Please read over Drupal commenting standards.
• In dacast_video.install, you still have the empty function dacast_video_field_schema(). Leave it out until you have something to put in the function.
• For functions called only during installation, use st(). From the get_t() page:
  

  Use t() if your code will never run during the Drupal installation phase. Use st() if your code will only run during installation and never any other time. Use get_t() if your code could run in either circumstance.

• In dacast_view.info, you list the dependency as dacast_streaming_as_a_service_integration. It should be dacast_video.
• As thambda said, in your uninstall function, you should check to make sure the user wants to delete all dacast nodes before just removing them from the database.
• Visiting /admin/dacast gives the following error:
  Warning: Parameter 1 to dacast_video_list_form() expected to be a reference, value given in drupal_retrieve_form() (line 798 of \includes\form.inc).. In hook_form, only $form_state is a reference.
• Visiting /admin/dacast/settings/add gives the following error:
  Notice: Undefined offset: 0 in dacast_video_config() (line 153 of C:\Users\Matt\workspace\drupal\sites\all\modules\dacast_video\dacast_video.module).
• In dacast_video_settings_edit(), you get a variable with a default value of a blank array then immediately access a value within that array. If the default value is ever used, that will cause an error.
• dacast_video_fetch() doesn't follow the proper function definition for hook_form().
• In dacast_video_config(), $text should be translated. So, too, should be the titles of all fields.
• Displayed text in dacast_video_fetch_all() needs to be translated.
• What is the point of drupal_get_messages(); on line 320 of dacast_video.module? It does nothing as it is.
• You have a lot of formatting issues in your code. The automated review should catch most of these.

Automated review:

There are a multitude of errors found by the automated review at ventral.org/pareview. See them here.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.