Do not show reply form if one of the users is blocked [#2008096]

I don't think the reply form should be shown on the message page if any of the users in the conversation have closed their accounts or been blocked. I realize that one could also argue that the reply form should not be shown only if all of the users have been blocked, since the conversation could continue without the blocked users.

This feature request is related to the issue here:
https://drupal.org/node/834706

Comment	File	Size	Author
#1	privatemsg-hide-reply-form-if-user-blocked-2008096-1.patch	1 KB	ptmkenny
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ptmkenny CreditAttribution: ptmkenny commented 30 May 2013 at 14:50

Status:

Active

» Needs review

File	Size
privatemsg-hide-reply-form-if-user-blocked-2008096-1.patch	1 KB

Comment #2

Berdir

German

Switzerland

CreditAttribution: Berdir commented 30 May 2013 at 14:54

That code is specific to users, that doesn't work, a recipient could also be a role.

What we need to check and what I thought we already did is simply if there are any valid recipients that we can write to.

If you look at privatemsg_form_reply(), you can see that it already does that and it even has logic to display the reasons why those users are blocked. So if the form is still displayed, you need to check why the check there isn't working.

Comment #3

ptmkenny CreditAttribution: ptmkenny commented 30 May 2013 at 15:35

Status:

Needs review

» Needs work

Ok, thanks for the comment. I missed the function call that performed validation.

I tried implementing this a different way by adding the following lines to _privatemsg_get_allowed_recipients() to make sure that the user account isn't blocked:

    // Do not add users who are blocked by Drupal as recipients
    if (!$recipient->status) {
      continue;
    }

However, the reply form is still shown because of this code:

    if ($recipient->type == 'user' && $recipient->recipient == $user->uid) {
      // Skip putting author in the recipients list for now.
      // Will be added if he is the only recipient.
      $usercount++;
      continue;

If I delete the line $usercount++, the reply form is hidden correctly. Why is the user added as the only recipient?