Allow to optionally turn of "successful" actions in watchdog. [#2008832]

I have a social site which is picking up in traffic. I have my watchdog set to 10,000 entries. This is filling up in a single day. That means I'm doing 10,000 database inserts and important failed messages could be lost in a bunch of cruft.

I'm going through contrib and patching the worst offenders of which apachesolr is one. Perhaps this is because I run apachesolr index in cron every two minutes, but there are two useless "you have succeeded" messages which fill up my watchdog (including the apache solr watchdog messages) and could potentially make me miss out on errors, which is what I really care about when browsing through watchdog.

Here's a patch which makes these messages optional. Additionally the admin interface has been make in the setting tabs of apachesolr.

Comment	File	Size	Author
#6	apachesolr-optional-success-watchdog-5.patch	10.5 KB	nick_vh
#4	apachesolr-optional-success-watchdog-3.patch	10.28 KB	nick_vh
#2	apachesolr-optional-success-watchdog-2.patch	1.74 KB	nick_vh
	apachesolr-optional-success-watchdog.patch	1.85 KB	j0rd

Comments

Comment #1

nick_vh

he/him

Ghent

commented 7 October 2013 at 19:34

@@ -511,6 +511,14 @@ function apachesolr_settings(array $form, array &$form_state) {
+    '#title' => t('Would you like successful solr actions to be logged'),
+    '#description' => t('Watchdog logs successful adds and indexes which happen with apache solr.'),

this should just be : "Log successful solr actions"

I'll rework it but I like the idea! And yes, I agree it should be enabled by default.

@@ -348,15 +348,19 @@ function apachesolr_index_send_to_solr($env_id, array $documents) {
+  if(variable_get('apachesolr_watchdog_successes', TRUE)) {

code standards require a space

@@ -348,15 +348,19 @@ function apachesolr_index_send_to_solr($env_id, array $documents) {
+    if(variable_get('apachesolr_watchdog_successes', TRUE)) {

code standards require a space between the verb and the opening (