.module rules_form_alter_rules_action_info(): various misspellings like: allways, Upadte, conatains etc. Please review.
.module LINE 119: misspelling in array index "elemet_array"
.module LINE 170 - 173: I think the strings here could go into the t() function.
.module: misspelled variable $crete_missing

reported by Stefan Lehmann
https://drupal.org/node/1990340#comment-7471020

CommentFileSizeAuthor
#1 spelling_fixed-2009172-1.patch6.39 KBandyhat

Comments

andyhat’s picture

andyhat commented
StatusFileSize
new spelling_fixed-2009172-1.patch6.39 KB

Corrections to the spellings following the issue summary.

guy_schneerson’s picture

guy_schneerson commented

Thanks @andyhat great job.

Only one unavoidable issue and that is that existing rules can break with a "Error: Missing configuration for parameter element_array." this is because element_array was renamed.

We can write an update to update existing rules but as this is still a sandbox I think it is reasonable to make this change.

If anyone runs into this issue they should role back to the previous commit and manually copy the values before updating.

guy_schneerson’s picture

guy_schneerson commented
Status: Active » Fixed

Committed http://drupalcode.org/sandbox/guy_schneerson/1791650.git/commit/7a783bf

guy_schneerson’s picture

guy_schneerson commented

Hi @andyhat the automated testing boot found a few small issues with your patch all where warning and easy to fix see #2013931: Coding standards - Warnings

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.