#556380-103: Remove OpenID from core requested someone to add openid back to contrib. Here's a patch to get it started.

CommentFileSizeAuthor
#5 openid_transfer_from_core-2010442-5.patch172.62 KBdeekayen
openid_transfer_from_core.patch2.92 KBdeekayen

Comments

deekayen’s picture

deekayen commented
Status: Active » Needs review

Naturally, I would get it started by setting the wrong initial status.

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

This looks like a patch that just removes all the code, how about importing it too? :)

deekayen’s picture

deekayen commented

wow. I could have sworn I added those back to the staging area before I diffed...

walkah’s picture

walkah commented
Version: 5.x-1.x-dev » master

Agreed, let's get a patch that actually adds the code and I'm happy to commit :-)

deekayen’s picture

deekayen commented
Status: Needs work » Needs review
StatusFileSize
new openid_transfer_from_core-2010442-5.patch172.62 KB

I made sure this one actually adds files this time. I diffed against master, as you signaled in #4.

ParisLiakos’s picture

ParisLiakos commented

why dont we move this through git so git history is preserved?

deekayen’s picture

deekayen commented
Status: Needs review » Needs work

I like the idea. Can't do it through patches though...

ParisLiakos’s picture

ParisLiakos commented

yeah a maintainer needs to do it

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented

walkah, can you do that?

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Needs work » Needs review

Okay, so I have access to do this, but I'm not really sure how.

I *think* this is what I need to do, but I wanted to run it by you guys first:

git clone git://drupalcode.org/project/drupal.git
cd drupal
git checkout f150c849b24e95b879307d8ae35d2634b760390d  # the commit right before blogapi was removed from core
git filter-branch --prune-empty --subdirectory-filter core/modules/openid 8.x
git remote add openid cweagans@git.drupal.org:project/openid.git
git push openid 8.x-1.x

Is that right?

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented

...anyone?

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Needs review » Fixed

Figured it out. We should establish an easy to follow process for moving modules from core to contrib, cause for people that don't do this particular operation very often, it can be very confusing.

http://drupalcode.org/project/openid.git/tree/refs/heads/8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.