tagnpin Referral module rewards customers for referrals and social sharing and Lets customers become brand ambassadors.

You can read more about tagNpin referral program on http://www.tagnpin.com

drupal Module repo : https://drupal.org/sandbox/tagnpin/1841462

1. Module inserts a simple javascript tracking code in the footer of the site to track referrals.

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxtagnpin1841462git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

ram4nd’s picture

Priority: Major » Normal
  • Fix all issues that PA robot points to.
  • Remove master branch and create corresponding branch: https://drupal.org/empty-git-master.
  • You say it's a simple module, you have two modules in your repository. Delete the empty one.
  • You should move your javascript to a separate file and pass variables form php (Like at the bottom of this page: http://browse-tutorials.com/tutorial/using-jquery-drupal-7).
  • I don't think this module requires a separate package.
  • This the quotes shouldn't be like this, but other way around (I know it works, but still)."<div id='tnpfloatbtn'></div>"
  • If you create variables you should add uninstall hook where you delete them on uninstall.

In overall it seems all too raw. With the commented out and sloppy code.

TimTheEnchanter’s picture

You have your repo bundled as if the module is a suite, but right now there is only one module, so your bundle should be simply

tagnpin
--tagnpin.info
--tagnpin.module

Later as you add modules to it you can rebundle them as a suite.

Fix the issues the PA scraper pointed out. Many seem to be simply white space and syntax errors. You can find the standard defined here https://drupal.org/coding-standards

You will also want to remove the commented out code snippets. After module approval you can add a dev branch that includes that stuff.

TimTheEnchanter’s picture

Another link you will want to check out is here https://drupal.org/node/1354

For example you have hooks with no commenting and that will not pass review, see below

/**
 * Implements hook_menu().
 */
function tagnpin_menu() {
sreynen’s picture

Title: Referral program powered by tagNpin » [D7] Referral program powered by tagNpin
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.