The name of the module

commerce_one_click_buy

A detailed description of what it does

This module adds one more button in addition to existing one (Add to cart button). The new button adds product item to shopping cart and redirects user to /checkout page.

Similar projects

A link to its sandbox project on Drupal.org

https://drupal.org/sandbox/petu/2012398
Direct ling to git: git clone http://git.drupal.org/sandbox/petu/2012398.git commerce_one_click_buy

The intended Drupal core version (eg. 6.x or 7.x)

Drupal 7 with Commerce.

Manual reviews of other projects

  1. https://drupal.org/node/2031345#comment-7601095
  2. https://drupal.org/node/2052201#comment-7744291

Comments

petu’s picture

Title: Commerce One click buy module » [D7] Commerce One click buy module
petu’s picture

Issue summary: View changes

Added text format.

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxpetu2012398git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

petu’s picture

Status: Needs work » Needs review

All errors from automated system have been fixed.

petu’s picture

Issue summary: View changes

Added direct link to git clone.

petu’s picture

Issue summary: View changes

Added link to reviewed project.

petu’s picture

Issue summary: View changes
petu’s picture

petu’s picture

Issue tags: +PAreview: review bonus
petu’s picture

Issue summary: View changes

Deleted a semicolon :)

klausi’s picture

Issue tags: -PAreview: review bonus, -commerce module +PAReview: Commerce

Removing review bonus tag, you have not all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I removed the automated review comments from the issue summary.

0mni’s picture

I reviewed what little code there is, not able to test as I do not have the commerce module. From what I can tell its very simple function. I thought there there was a minimum requirement for lines in the module so it can be submitted ?

I did see in the README.txt that the comments are not wrapped to 80 characters are required.

http://ventral.org/pareview/httpgitdrupalorgsandboxpetu2012398git

petu’s picture

Hello 0mni,

thank you for reviewing my module! I've fixed warning in README.txt file.

andyd328’s picture

Status: Needs review » Needs work

Hi,

The description needs completing in the .info file, currently: "description = Adds a button for quick ."

I'm not sure Commerce (shipping) is the best location for the module - how about "Commerce (contrib)" ?

I installed the module on a clean Commerce Kickstart install with the demo products.
With the module enabled the 'One click buy' button appeared.
Clicking it did take me to the checkout, but I still got the pop up offering me 'Continue shopping' or 'Go to Checkout'.
'Continue shopping' took me to the same place as 'Checkout' - the checkout - and the pop up meant it was no longer one click to get to the checkout, it was the same two clicks as usual. Can the popup be disabled if the module is enabled?

The comments at the top of .module are from the devel module - they should really be replaced them with something relevant to this module.

petu’s picture

Assigned: Unassigned » petu

Hello Andy!

Thank you for reviewing the module!

The description needs completing in the .info file, currently: "description = Adds a button for quick ."

Fixed.

I'm not sure Commerce (shipping) is the best location for the module - how about "Commerce (contrib)" ?

Fixed. Location is Commerce (contrib) now.

The comments at the top of .module are from the devel module - they should really be replaced them with something relevant to this module.

You are right :), fixed!

petu’s picture

Assigned: Unassigned » petu
Status: Needs review » Needs work

I installed the module on a clean Commerce Kickstart install with the demo products.
With the module enabled the 'One click buy' button appeared.
Clicking it did take me to the checkout, but I still got the pop up offering me 'Continue shopping' or 'Go to Checkout'.
'Continue shopping' took me to the same place as 'Checkout' - the checkout - and the pop up meant it was no longer one click to get to the checkout, it was the same two clicks as usual. Can the popup be disabled if the module is enabled?

It's because of commerce_add_to_cart_confirmation module. It already has an issue #1937566: Add to cart confirmation shouldn't show on cart.

petu’s picture

Assigned: petu » Unassigned
Status: Needs work » Needs review
petu’s picture

Assigned: petu » Unassigned
Status: Needs work » Needs review

I installed the module on a clean Commerce Kickstart install with the demo products.
With the module enabled the 'One click buy' button appeared.
Clicking it did take me to the checkout, but I still got the pop up offering me 'Continue shopping' or 'Go to Checkout'.
'Continue shopping' took me to the same place as 'Checkout' - the checkout - and the pop up meant it was no longer one click to get to the checkout, it was the same two clicks as usual. Can the popup be disabled if the module is enabled?

Added a patch for #1937566: Add to cart confirmation shouldn't show on cart to fix this issue.

petu’s picture

Issue summary: View changes

removed automated reviews.

kscheirer’s picture

Status: Needs review » Needs work
Code too short
This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

This could also perhaps go in as feature to commerce or commerce_direct_buy since it's just a few lines of code.

----
Top Shelf Modules - Crafted, Curated, Contributed.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Issue summary: View changes

Added one more manual reviewed project.

petu’s picture

Issue summary: View changes
Status: Closed (won't fix) » Active

Created issue to integrate this feature to the commerce project.

PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2012412

Project 2: https://www.drupal.org/node/2301411

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

petu’s picture

Status: Active » Closed (duplicate)
avpaderno’s picture

Issue tags: -
Related issues: +#2301411: [D7] Commerce Options as Images