Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Jun 2013 at 08:18 UTC
Updated:
9 Sep 2018 at 23:28 UTC
Jump to comment: Most recent
Comments
Comment #1
petu commentedComment #1.0
petu commentedAdded text format.
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxpetu2012398git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
petu commentedAll errors from automated system have been fixed.
Comment #3.0
petu commentedAdded direct link to git clone.
Comment #3.1
petu commentedAdded link to reviewed project.
Comment #3.2
petu commentedAdded one more review https://drupal.org/node/1987552#comment-7601037.
Comment #3.3
petu commentedAdded https://drupal.org/node/2031345#comment-7601095 as reviewed.
Comment #4
petu commentedComment #4.0
petu commentedDeleted a semicolon :)
Comment #5
klausiRemoving review bonus tag, you have not all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.
I removed the automated review comments from the issue summary.
Comment #6
0mni commentedI reviewed what little code there is, not able to test as I do not have the commerce module. From what I can tell its very simple function. I thought there there was a minimum requirement for lines in the module so it can be submitted ?
I did see in the README.txt that the comments are not wrapped to 80 characters are required.
http://ventral.org/pareview/httpgitdrupalorgsandboxpetu2012398git
Comment #7
petu commentedHello 0mni,
thank you for reviewing my module! I've fixed warning in README.txt file.
Comment #8
andyd328Hi,
The description needs completing in the .info file, currently: "description = Adds a button for quick ."
I'm not sure Commerce (shipping) is the best location for the module - how about "Commerce (contrib)" ?
I installed the module on a clean Commerce Kickstart install with the demo products.
With the module enabled the 'One click buy' button appeared.
Clicking it did take me to the checkout, but I still got the pop up offering me 'Continue shopping' or 'Go to Checkout'.
'Continue shopping' took me to the same place as 'Checkout' - the checkout - and the pop up meant it was no longer one click to get to the checkout, it was the same two clicks as usual. Can the popup be disabled if the module is enabled?
The comments at the top of .module are from the devel module - they should really be replaced them with something relevant to this module.
Comment #9
petu commentedHello Andy!
Thank you for reviewing the module!
Fixed.
Fixed. Location is Commerce (contrib) now.
You are right :), fixed!
Comment #10
petu commentedIt's because of commerce_add_to_cart_confirmation module. It already has an issue #1937566: Add to cart confirmation shouldn't show on cart.
Comment #11
petu commentedComment #12
petu commentedAdded a patch for #1937566: Add to cart confirmation shouldn't show on cart to fix this issue.
Comment #12.0
petu commentedremoved automated reviews.
Comment #13
kscheirerThis could also perhaps go in as feature to commerce or commerce_direct_buy since it's just a few lines of code.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #14
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14.0
PA robot commentedAdded one more manual reviewed project.
Comment #15
petu commentedCreated issue to integrate this feature to the commerce project.
Comment #16
PA robot commentedProject 1: https://www.drupal.org/node/2012412
Project 2: https://www.drupal.org/node/2301411
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #17
petu commentedComment #18
avpaderno